Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(updatecli): add manifests for hadolint & shellcheck in tools scripts #1858

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

lemeurherve
Copy link
Member

@lemeurherve lemeurherve commented Apr 24, 2024

This PR adds updatecli manifests for keeping the versions of hadolint & shellcheck up to date in the ./tools scripts.

Testing done

Local tests + CI

Dry run outputs:

hadolint

✔ GitHub release version "v2.12.0" found matching pattern "*" of kind "semver"


CHANGELOG:
----------

Release published on the 2022-11-09 18:20:48 +0000 UTC at the url https://github.com/hadolint/hadolint/releases/tag/v2.12.0

**Full Changelog**: https://github.com/hadolint/hadolint/compare/v2.11.0...v2.12.0

* Try a newer GHC version for valid MacOS Ventura builds


TARGETS
========

updateVersion
-------------

**Dry Run enabled**

✔ - all contents from 'file' and 'files' combined already up to date

shellcheck

"tools/shellcheck" updated with [dry run] content "koalaman/shellcheck:v0.10.0 "

--- tools/shellcheck
+++ tools/shellcheck
@@ -3,4 +3,4 @@
 exec docker run --rm \
     -w "${PWD}" \
     -v "${PWD}:${PWD}" \
-    koalaman/shellcheck:v0.9.0 "$@"
+    koalaman/shellcheck:v0.10.0 "$@"

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

@lemeurherve lemeurherve requested a review from a team as a code owner April 24, 2024 20:42
@lemeurherve lemeurherve changed the title chore(updatecli): add manifest for tools/hadolint & tools/shellcheck chore(updatecli): add manifest for hadolint & shellcheck in tools scripts Apr 24, 2024
@lemeurherve lemeurherve changed the title chore(updatecli): add manifest for hadolint & shellcheck in tools scripts chore(updatecli): add manifests for hadolint & shellcheck in tools scripts Apr 24, 2024
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@MarkEWaite
Copy link
Contributor

The updatecli dry run looks good. Merging since the other tests in the CI job do not evaluate the updatecli changes.

@MarkEWaite MarkEWaite merged commit a04c1f4 into jenkinsci:master Apr 24, 2024
14 of 16 checks passed
@lemeurherve lemeurherve deleted the tools-updatecli-manifests branch April 24, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants