Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaling down to zero instances works, but then won't scale back up #52

Closed
VackarAfzal opened this issue Feb 6, 2019 · 6 comments
Closed

Comments

@VackarAfzal
Copy link

VackarAfzal commented Feb 6, 2019

When settings the min number of instances to zero, the plugin will successfully scale the instances down after the defined idle time. It doesn't however then scale up the desire size once job start coming in.

I've tested this with a build queue size of 1, 5, 10 and executors (per node) of 1 and 4

edit: Just to give some context, this only occurs when I have other nodes that I explicitly mark as offline. As soon as I delete the offline nodes, scaling works as expected.

@ianfixes
Copy link

ianfixes commented Mar 29, 2019

Subscribed, I may have this problem as well

@ebalakumar
Copy link

@VackarAfzal . In my case Target capacity and min size works weirdly or please correct me if my understanding is wrong . When I keep the Target capacity in jenkins as 2 and min size as 0 . It immediately sets the target capacity to two in the spot fleet when there is a job which does not require that much . is it supposed to create just one and scale up based on demand ???

@fruch
Copy link

fruch commented Jun 26, 2019

happens to me as well, i'm using 1.5.0 version

Any idea which logs might help to solve this issue ? it's kind of a key feature for this plugin, i.e. don't waste money on idle spots, hence we want the min target to be 0

@terma
Copy link

terma commented Jun 26, 2019

Hi, @fruch do you have a problem during scale up or initial capacity? The original issue about scale up while comments about initial. Could you please provide your use case. Thx

@fruch
Copy link

fruch commented Jun 30, 2019

My problem is that when I have a fleet target capacity set to 0, the plugin doesn't update the target capacity to what's to match the jobs waiting in the queue.
when I update the target manually, things start working.
but after the plugin set the target back to 0, its again doesn't scale back up on the next runs that need the label configured for the fleet

@terma
Copy link

terma commented Jul 2, 2019

Ok, got it, looks like existent issue #43 will close this one to keep single thread, feel free to reopen if you think it's diff. Thx.

@terma terma closed this as completed Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants