Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-47574] NPE in EnvInjectAction#getEnvironment() when the build is not fully loaded #50

Closed
NotMyFault opened this issue Oct 22, 2017 · 5 comments

Comments

@NotMyFault
Copy link
Member

It happens when getEnvironment() is being called from readResolve(). I occasionally deleted it during the FindBugs cleanup


Originally reported by oleg_nenashev, imported from: NPE in EnvInjectAction#getEnvironment() when the build is not fully loaded
  • assignee: oleg_nenashev
  • status: Resolved
  • priority: Minor
  • resolution: Done
  • resolved: 2017-10-24T06:26:12+00:00
  • imported: 2022-10-20
@NotMyFault
Copy link
Member Author

scm_issue_link:

Code changed in jenkins
User: Oleg Nenashev
Path:
src/main/java/org/jenkinsci/lib/envinject/EnvInjectAction.java
http://jenkins-ci.org/commit/envinject-lib/cb7ba5af53a3f6dcd709ca39d1c547378092fc88
Log:
JENKINS-47574 - Be protective against null parents in readResolve()

@NotMyFault
Copy link
Member Author

scm_issue_link:

Code changed in jenkins
User: Oleg Nenashev
Path:
src/main/java/org/jenkinsci/lib/envinject/EnvInjectAction.java
http://jenkins-ci.org/commit/envinject-lib/a5da0e1f1a87a35a9f7a30da841b68acb2af7a33
Log:
JENKINS-47574 - Fix the comparison logic

@NotMyFault
Copy link
Member Author

scm_issue_link:

Code changed in jenkins
User: Oleg Nenashev
Path:
src/main/java/org/jenkinsci/lib/envinject/EnvInjectAction.java
http://jenkins-ci.org/commit/envinject-lib/7da8f74f5b9a4d45cb27d7f62256e196f9ae2e3a
Log:
Merge pull request #14 from oleg-nenashev/bug/JENKINS-47574

JENKINS-47574 - Prevent NPE in EnvInjectAction#getEnvironment() when it's called in readResolve()

Compare: jenkinsci/envinject-lib@e2d0a75...7da8f74

@NotMyFault
Copy link
Member Author

scm_issue_link:

Code changed in jenkins
User: Oleg Nenashev
Path:
pom.xml
http://jenkins-ci.org/commit/envinject-api-plugin/3e16ce5885cd361b57a304b6e0a4272717eb0c7f
Log:
[JENKINS-47574, JENKINS-47167] - Update to EnvInject Lib 1.28

@NotMyFault
Copy link
Member Author

oleg_nenashev:

It has been released in EnvInject Lib 1.28 and EnvInject API 1.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant