Skip to content

Commit

Permalink
improve header variable name description
Browse files Browse the repository at this point in the history
Version 1.28 introduced RFC 2616 compatibility making all headers lowercase.

This patch adds a note to make this fact more obvious.

Example situation where this matters: a CI systems that checks for X-GitHub-Event header to make further decisions. Since 1.28 the resulting variable changes from X_GitHub_Event to x_github_event effectively breaking this process.
  • Loading branch information
jekader committed Mar 8, 2018
1 parent 548877b commit 0fd8196
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?jelly escape-by-default='true'?>
<j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" xmlns:l="/lib/layout" xmlns:t="/lib/hudson" xmlns:f="/lib/form">
<f:entry title="Request header" description="Name of request header. Resulting variable name has '_' instead of '-' characters.">
<f:entry title="Request header" description="Name of request header in lowercase. Resulting variable name has '_' instead of '-' characters.">
<f:textbox field="key"/>
</f:entry>

Expand Down

0 comments on commit 0fd8196

Please sign in to comment.