Skip to content

Commit

Permalink
More information in log if variable cannot be resolved #29
Browse files Browse the repository at this point in the history
  • Loading branch information
tomasbjerre committed Dec 20, 2017
1 parent ad58a6a commit 19443b4
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 1 deletion.
16 changes: 16 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,22 @@
# Generic Webhook Plugin Changelog
Changelog of Generic Webhook Plugin.
## Unreleased
### GitHub [#26](https://github.com/jenkinsci/generic-webhook-trigger-plugin/issues/26) JSONPath processing seems to not handle "," operator

**Test case with comma operator #26**


[ad58a6aadbdaf32](https://github.com/jenkinsci/generic-webhook-trigger-plugin/commit/ad58a6aadbdaf32) Tomas Bjerre *2017-11-15 18:37:55*


### GitHub [#29](https://github.com/jenkinsci/generic-webhook-trigger-plugin/issues/29) Unable to resolve variable

**More information in log if variable cannot be resolved #29**


[41d34ee48f05639](https://github.com/jenkinsci/generic-webhook-trigger-plugin/commit/41d34ee48f05639) Tomas Bjerre *2017-12-20 18:49:24*


### No issue

**Doc**
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package org.jenkinsci.plugins.gwt.resolvers;

import static com.google.common.collect.Maps.newHashMap;
import static java.util.logging.Level.INFO;
import static org.jenkinsci.plugins.gwt.ExpressionType.JSONPath;
import static org.jenkinsci.plugins.gwt.ExpressionType.XPath;

Expand Down Expand Up @@ -59,7 +60,17 @@ private Map<String, String> resolve(String incomingPostContent, GenericVariable
}
}
} catch (final Exception e) {
LOGGER.info("Unable to resolve " + gv.getVariableName());
LOGGER.log(
INFO,
"Unable to resolve "
+ gv.getVariableName()
+ " with "
+ gv.getExpressionType()
+ " "
+ gv.getExpression()
+ " in\n"
+ incomingPostContent,
e);
}
return new HashMap<>();
}
Expand Down

0 comments on commit 19443b4

Please sign in to comment.