Avoiding NPE for parameters without value #62

jenkinsci · Jul 10, 2018 · 3dcdd66 · 3dcdd66
1 parent 6e47573
commit 3dcdd66
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,12 +1,12 @@
 # Generic Webhook Plugin Changelog
 Changelog of Generic Webhook Plugin.
 ## Unreleased
-### GitHub [#62](https://github.com/jenkinsci/generic-webhook-trigger-plugin/issues/62) NullPointerException when trying to trigger job  
+### No issue
 
-**Adding a jenkinsfile with defaults #62**
+**Adding a jenkinsfile with defaults**
 
 
-[fccc83aa293979b](https://github.com/jenkinsci/generic-webhook-trigger-plugin/commit/fccc83aa293979b) Tomas Bjerre *2018-07-09 20:16:37*
+[6e47573b2926fbd](https://github.com/jenkinsci/generic-webhook-trigger-plugin/commit/6e47573b2926fbd) Tomas Bjerre *2018-07-09 20:48:34*
 
 
 ## 1.39 (2018-06-25 18:17:02)

diff --git a/src/main/java/org/jenkinsci/plugins/gwt/ParameterActionUtil.java b/src/main/java/org/jenkinsci/plugins/gwt/ParameterActionUtil.java
@@ -70,6 +70,9 @@ private static String getStringValue(
     if (!isNullOrEmpty(resolvedVariables.get(param))) {
       return resolvedVariables.get(param);
     }
+    if (defaultParameterValue.getValue() == null) {
+      return "";
+    }
     return defaultParameterValue.getValue().toString();
   }
 }