Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: update commit status while waiting for permission to test a PR #152

Closed
ixdy opened this issue Jul 24, 2015 · 4 comments
Closed

Comments

@ixdy
Copy link
Contributor

ixdy commented Jul 24, 2015

The developers on our project feel safe to merge a PR when all of the commit checks are green, including usually our Jenkins run.

However, if the Jenkins plugin asks for permission to test a PR, it doesn't update the commit status, and so a developer may miss that the tests weren't run. (For example, this recently happened on kubernetes/kubernetes#11379.)

If the plugin would mark a commit as pending while waiting for permission to run tests, it would make it very obvious that tests hadn't run yet. (Extra bonus if the commit status mentioned that it was waiting for permission.)

@mikedanese
Copy link

+1 this option would be super helpful.

@pmorie
Copy link

pmorie commented Sep 9, 2015

+1

@bjoernhaeuser
Copy link
Contributor

For me it looks like this will be closed by #398

@bjoernhaeuser
Copy link
Contributor

Closing this in favor of #398

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants