Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating tests of GitAPITestCase from JUnit 3 to JUnit 4 #674

Merged
merged 6 commits into from
Feb 24, 2021

Conversation

GAyan17
Copy link
Contributor

@GAyan17 GAyan17 commented Feb 23, 2021

JENKINS-60940 - Migrating tests of GitAPITestCase from JUnit 3 to JUnit 4

In this PR, the test migrated is:

  • testCleanWithParameters
  • testClean
  • testHasGitRepo

Describe the big picture of your changes here to explain to the maintainers why this pull request should be accepted.
If it fixes a bug or resolves a feature request, include a link to the issue.

Checklist

  • I have read the CONTRIBUTING doc
  • I have referenced the Jira issue related to my changes in one or more commit messages
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes
  • I have interactively tested my changes

Types of changes

What types of changes does your code introduce?

  • Tests

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to have the changes reverted that are purely white space. White space changes make other pull requests have unnecessary conflicts. See the CONTRIBUTING file for more details describing why this plugin needs to leave its ugly formatting alone.

Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
@GAyan17
Copy link
Contributor Author

GAyan17 commented Feb 23, 2021

Thanks @MarkEWaite for the code suggestion review, I will surely keep that in mind for other pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Automated test addition or improvement
Projects
None yet
2 participants