-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrating Tests From JUnit 3 (GitAPITesCase) to JUnit 4 (GitAPITest) #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To keep conflicts as minimal as possible.
MarkEWaite
requested changes
Feb 24, 2021
MarkEWaite
approved these changes
Feb 25, 2021
This was referenced Mar 18, 2021
MarkEWaite
added a commit
to MarkEWaite/bom
that referenced
this pull request
Sep 2, 2021
Git client plugin 3.6.0 does not include jenkinsci/git-client-plugin#675 that resolves a test failure with command line git 2.33 and later. Git client plugin 3.7.0 and later include that fix. Git client plugin 3.6.0 also does not include the change for git LFS execution on ci.jenkins.io. This exclusion will no longer be needed when the bom drops support for 2.249.x.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-60940 - Migrating Tests From JUnit 3 (GitAPITesCase) to JUnit 4 (GitAPITest)
Describe the big picture of your changes here to explain to the maintainers why this pull request should be accepted.
If it fixes a bug or resolves a feature request, include a link to the issue.
Tests Migrated in this PR:
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. This is simply a reminder of what we are going to look for before merging your code.Types of changes
What types of changes does your code introduce? Put an
x
in the boxes that applyFurther comments
initializeWorkspace()
to initialize the workspace with basic git initialization, also it made initialization of remote and bare workspaces easier.