Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup getInstance() references #683

Merged
merged 1 commit into from
Mar 9, 2021
Merged

Cleanup getInstance() references #683

merged 1 commit into from
Mar 9, 2021

Conversation

darinpope
Copy link
Contributor

@darinpope darinpope commented Mar 9, 2021 •
edited by MarkEWaite

Cleanup getInstance() references

Replace Jenkins.getInstance() with either Jenkins.get() or other appropriate non-deprecated replacement.

Checklist

  • I have read the CONTRIBUTING doc
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes
  • I have interactively tested my changes

Types of changes

  • Infrastructure change (non-breaking change which updates dependencies or improves infrastructure)
  • Bug fix (non-breaking change which fixes an issue)

@MarkEWaite

MarkEWaite
MarkEWaite approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@MarkEWaite MarkEWaite merged commit 150db75 into jenkinsci:master Mar 9, 2021
@darinpope darinpope deleted the getInstance branch March 9, 2021 17:47
@MarkEWaite MarkEWaite added chore Reduces maintenance effort by changes not directly visible to users and removed bugfix labels Mar 12, 2021
This was referenced Mar 18, 2021
Closed
Merged
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
chore Reduces maintenance effort by changes not directly visible to users
Projects
None yet
Milestone
No milestone
2 participants
@darinpope @MarkEWaite