Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make git-client compatible with future guava #686

Merged
merged 1 commit into from
Mar 14, 2021

Conversation

timja
Copy link
Member

@timja timja commented Mar 14, 2021

See jenkinsci/bom#423

and example merged PR in a pipeline component: jenkinsci/workflow-support-plugin#114

cc @MarkEWaite

@MarkEWaite MarkEWaite merged commit 6d63e59 into jenkinsci:master Mar 14, 2021
@timja timja deleted the future-guava-update branch March 14, 2021 15:57
@timja
Copy link
Member Author

timja commented Mar 14, 2021

@MarkEWaite could you release this please?

@MarkEWaite
Copy link
Contributor

@MarkEWaite could you release this please?

Sure, though I want some interactive test time before I release it. I will want to release git plugin as well, since it also increases its minimum Jenkins version to 2.249.1, just as the master branch of the git client plugin does.

@timja
Copy link
Member Author

timja commented Mar 14, 2021

sure you can hold off a bit anyway, I'm going to try a no reflection approach based off of jenkinsci/workflow-support-plugin#117

@MarkEWaite MarkEWaite added the chore Reduces maintenance effort by changes not directly visible to users label Mar 14, 2021
@timja
Copy link
Member Author

timja commented Mar 14, 2021

think I'll leave it a lot of classes need vendoring unless @basil wants to give it a go?

@basil
Copy link
Member

basil commented Mar 14, 2021

Vendoring DirectExecutorService seems like more trouble than it's worth. This solution seems fine.

@MarkEWaite
Copy link
Contributor

@timja and @basil I'd like to wait until the official release of JGit 5.11.0 on 17 Mar 2021 before this is released. That also allows me a few days to re-evaluate the user impact of #673. It adds more noise to the console log and provide benefit to a very narrow set of users.

@timja
Copy link
Member Author

timja commented Mar 15, 2021

makes sense looks like that PR should be tweaked, will follow up later on if required

@MarkEWaite
Copy link
Contributor

Released as git client plugin 3.7.0 17 Mar 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Reduces maintenance effort by changes not directly visible to users
Projects
None yet
3 participants