-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support GH organization folders #1
Comments
Apparently this functionality was rolled into the github branch source plugin, so just make sure we support it there. |
Hey, what is the status of this? Is there any way that I could register a rebuild to happen when a comment with specific text contents (as this plugin is described) is posted to a PR when using the Github branch source plugin? |
Yes, the functionality is working - I just haven't verified support with GitHub organization folders yet. |
cool, could you point me to an example of using this with a jenkinsfile or pipeline script? we haven't been able to figure out how to get called from there. |
@bluesliverx In a GHO folder, the branch configuration is read-only, so you'll need folder-level config. |
any news? |
@samdmarshall please see #4 and #5 for more info on calling it from Jenkinsfile or pipeline scripts, this is not the way the plugin is intended to be used. It must be configured on the multibranch job. @gimler as for GH organization folders, I haven't looked into them at all since we don't use them at all currently. That may change in the future, but it likely will not be soon. I'm very open to PRs to add this functionality if you figure out how to do this. Sorry I don't have a better answer, but since this is for work and I don't use this functionality in my home projects, I'm kind of limited to what I can do here. |
It looks like this is actually only possible (without a lot of work on this plugin) through the pipeline script as long as you have the "Pipeline GitHub" plugin installed: https://github.com/jenkinsci/pipeline-github-plugin#issuecommenttrigger If you add that trigger to your pipeline script, it should trigger correctly, according to the docs. I'm closing this ticket since according to this Jenkins ticket, it is by design that branch properties cannot be configured on github orgs. It should all be done through pipeline scripts for them. |
From Jesse Glick:
BranchProperty will not suffice for a GH org folder I think. You would need an AbstractFolderProperty<OrganizationFolder>.
The text was updated successfully, but these errors were encountered: