Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can we support the addition of labels as a feature to trigger? #13

Open
borisivan opened this issue May 17, 2019 · 3 comments
Open

can we support the addition of labels as a feature to trigger? #13

borisivan opened this issue May 17, 2019 · 3 comments

Comments

@borisivan
Copy link

Given that the logic is probably very similar, can we support the PR build to occur on the addition of a label? That event is sent from GH, but I don't know of any plugins that allow the build to occur when it receives that event.

It would seem that it would be pretty similar to https://github.com/jenkinsci/github-pr-comment-build-plugin/blob/master/src/main/java/com/adobe/jenkins/github_pr_comment_build/IssueCommentGHEventSubscriber.java but just subscribing to a different event action. (created: label, I think)

I'm mentioning this here because it really does seem related, and also makes things foolproof. When users need to type a certain phrase, typos can be a fact of life. Adding one (or more) of a specific predefined label removes some of that concern, and is a great way to differentiate PRs without needing to parse all the (potentially many!) comments, etc. etc.

@bluesliverx
Copy link
Contributor

This does seem related to me, perhaps the plugin should have been called "pr-change-build" :) I don't have the time to add this, but I welcome PRs and can get it released pretty quickly if you were to add the functionality.

@bluesliverx
Copy link
Contributor

Note, this would look very similar to what was added for reviews: eda2dbd

@AgyaeyTiwari
Copy link
Contributor

AgyaeyTiwari commented Apr 6, 2023

Raised a PR: #62
@bluesliverx Can you please check above PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants