Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Code Cleanup]: Make ComputeEngineCloud NodeProvisioner compatible #76

Open
craigdbarber opened this issue Apr 16, 2019 · 0 comments
Open

[Code Cleanup]: Make ComputeEngineCloud NodeProvisioner compatible #76

craigdbarber opened this issue Apr 16, 2019 · 0 comments
Labels
backlog Issues that we are not currently addressing

Comments

@craigdbarber
Copy link
Contributor

[Migrated from: https://issues.jenkins-ci.org/browse/JENKINS-55412]

When provisioning nodes in ComputeEngineCloud the code currently does a direct out of band call to jenkins.getInstance().addNode(). This is antithetical to the NodeProvisioner workflow which expects to call jenkins.getInstance().addNode() when the PlannedNode's future successfully returns.
@craigdbarber craigdbarber added the enhancement New feature or request label Apr 16, 2019
@stephenashank stephenashank added backlog Issues that we are not currently addressing and removed enhancement New feature or request labels Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog Issues that we are not currently addressing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stephenashank @craigdbarber