-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
/
NodesTest.java
123 lines (111 loc) · 5.08 KB
/
NodesTest.java
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
/*
* The MIT License
*
* Copyright 2018 CloudBees, Inc.
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
* in the Software without restriction, including without limitation the rights
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the Software is
* furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in
* all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
* THE SOFTWARE.
*/
package jenkins.model;
import hudson.model.Descriptor;
import hudson.model.Node;
import hudson.model.Slave;
import hudson.slaves.ComputerLauncher;
import java.io.IOException;
import org.junit.Rule;
import org.junit.Test;
import org.jvnet.hudson.test.Issue;
import org.jvnet.hudson.test.JenkinsRule;
import static org.hamcrest.Matchers.containsString;
import static org.hamcrest.Matchers.nullValue;
import static org.hamcrest.Matchers.sameInstance;
import static org.junit.Assert.assertThat;
import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.fail;
public class NodesTest {
@Rule
public JenkinsRule r = new JenkinsRule();
@Test
@Issue("JENKINS-50599")
public void addNodeShouldFailAtomically() throws Exception {
InvalidNode node = new InvalidNode("foo", "temp", r.createComputerLauncher(null));
try {
r.jenkins.addNode(node);
fail("Adding the node should have thrown an exception during serialization");
} catch (IOException e) {
String className = InvalidNode.class.getName();
assertThat("The exception should be from failing to serialize the node",
e.getMessage(), containsString("Failed to serialize " + className + "#cl for class " + className));
}
assertThat("The node should not exist since #addNode threw an exception",
r.jenkins.getNode("foo"), nullValue());
}
@Test
@Issue("JENKINS-50599")
public void addNodeShouldFailAtomicallyWhenReplacingNode() throws Exception {
Node oldNode = r.createSlave("foo", "", null);
r.jenkins.addNode(oldNode);
InvalidNode newNode = new InvalidNode("foo", "temp", r.createComputerLauncher(null));
try {
r.jenkins.addNode(newNode);
fail("Adding the node should have thrown an exception during serialization");
} catch (IOException e) {
String className = InvalidNode.class.getName();
assertThat("The exception should be from failing to serialize the node",
e.getMessage(), containsString("Failed to serialize " + className + "#cl for class " + className));
}
assertThat("The old node should still exist since #addNode threw an exception",
r.jenkins.getNode("foo"), sameInstance(oldNode));
}
@Test
public void addNodeShouldReplaceExistingNode() throws Exception {
Node oldNode = r.createSlave("foo", "", null);
r.jenkins.addNode(oldNode);
Node newNode = r.createSlave("foo", "", null);
r.jenkins.addNode(newNode);
assertThat(r.jenkins.getNode("foo"), sameInstance(newNode));
}
@Test
@Issue("JENKINS-56403")
public void replaceNodeShouldRemoveOldNode() throws Exception {
Node oldNode = r.createSlave("foo", "", null);
Node newNode = r.createSlave("foo-new", "", null);
r.jenkins.addNode(oldNode);
r.jenkins.getNodesObject().replaceNode(oldNode, newNode);
r.jenkins.getNodesObject().load();
assertNull(r.jenkins.getNode(oldNode.getNodeName()));
}
@Test
@Issue("JENKINS-56403")
public void replaceNodeShouldNotRemoveIdenticalOldNode() throws Exception {
Node oldNode = r.createSlave("foo", "", null);
Node newNode = r.createSlave("foo", "", null);
r.jenkins.addNode(oldNode);
r.jenkins.getNodesObject().replaceNode(oldNode, newNode);
r.jenkins.getNodesObject().load();
assertNotNull(r.jenkins.getNode(oldNode.getNodeName()));
}
private static class InvalidNode extends Slave {
// JEP-200 whitelist changes prevent this field (and thus instances of this class) from being serialized.
private ClassLoader cl = InvalidNode.class.getClassLoader();
public InvalidNode(String name, String remoteFS, ComputerLauncher launcher) throws Descriptor.FormException, IOException {
super(name, remoteFS, launcher);
}
}
}