Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow plugin to compile against newer baselines #41

Merged
merged 1 commit into from Dec 18, 2014

Conversation

jglick
Copy link
Member

@jglick jglick commented Dec 15, 2014

Trying to make

mvn clean install

work when you specify a newer baseline. See also my comment on 2b92f83.

jglick referenced this pull request Dec 15, 2014
…ted.

So fix hudson.plugins.jobConfigHistory.JobConfigHistoryJobListenerIT.testRenameErrors():void to catch the RTE when
things go wrong.
@jglick
Copy link
Member Author

jglick commented Dec 15, 2014

(Background: while working on jenkinsci/jenkins#1379 I was looking for occurrences of yyyy-MM-dd_HH-mm-ss|ID_FORMATTER|getIDFormatter that might get broken. But I think your JobConfigHistoryConsts.ID_FORMATTER is not actually related and just happens to use the same name and pattern.)

@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@stefanbrausch
Copy link
Member

Hi @mfriedenhagen could you take a look on this pull request please. It's your code ;-)

@jglick
Copy link
Member Author

jglick commented Dec 17, 2014

This PR is I think not controversial; Callable is only being used internally in the test, not in reference to Remoting APIs, so switching to the Java-standard version should have no side effects.

stefanbrausch pushed a commit that referenced this pull request Dec 18, 2014
Allow plugin to compile against newer baselines
@stefanbrausch stefanbrausch merged commit c2fb690 into jenkinsci:master Dec 18, 2014
@jglick jglick deleted the test-against-new-baseline branch December 18, 2014 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants