Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acquiring of empty resource if timeout is expired #24

Closed
SDCFWM opened this issue Dec 22, 2015 · 1 comment
Closed

Acquiring of empty resource if timeout is expired #24

SDCFWM opened this issue Dec 22, 2015 · 1 comment

Comments

@SDCFWM
Copy link

SDCFWM commented Dec 22, 2015

Following the hard-coded timeout is for how long the resource might be queued(reserved) before it's acquired.
Class LockableResource.java:
private static final int QUEUE_TIMEOUT = 5;
If the timeout is expired a resource will be unqueued from the queue and an empty resource will be acquired by plugin:
[lockable-resources] acquired lock on []
The possible workaround might be to increase the timeout to some significant value.
However, it does not fix the issue. Plugin should check if acquired resource is empty and somehow react, for example, ask to acquire a resource one more time.

@SDCFWM SDCFWM changed the title Acquiring of empty resource if timeout is erxpired Acquiring of empty resource if timeout is expired Dec 22, 2015
@jimklimov
Copy link
Contributor

I think this is not a problem currently, a job can be blocked for hours waiting for a resource.
Looking at comments elsewhere, the timeout may be on the queue processing code - that a verdict about a job must be returned quickly (ready to execute or not?), as addressed by e.g. #171 to cache scripted verdicts that can take time to collect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants