Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending scope parameter with a token request is not configurable #185

Closed
rlee-metrodigital opened this issue Dec 15, 2022 · 3 comments · Fixed by #188
Closed

Sending scope parameter with a token request is not configurable #185

rlee-metrodigital opened this issue Dec 15, 2022 · 3 comments · Fixed by #188
Assignees
Milestone

Comments

@rlee-metrodigital
Copy link

Hello this is an inquiry following up on #62 which was created to see if not sending the scope parameter would cause any issues for users changed in #46

This indeed seems to cause an issue for our openid implementation, i.e. the scope is required. So downgrading to 1.5 resolved the issues, the release right before the changes in #46 were applied.

As far as I can tell, configuring the plugin so that that scope parameters can be passed in the token request is not possible and it seems this was planned (noting this comment #62 (comment)).

@ivankorn
Copy link

@mjmbischoff would you mind reverting your change?

That makes me pinning version to 1.5 and I can't use any newer one. Looks like there are a few requests for the same.

@michael-doubez
Copy link
Contributor

Hello

I'll rather make it configurable. OpenID connect didn't allow it but providers tend to be less strict.
Especially with jwt token of implicit flow replacing code flow.

I'll schedule it to be in the next release.

@michael-doubez michael-doubez self-assigned this Dec 15, 2022
@michael-doubez michael-doubez added this to the 2.4 milestone Dec 15, 2022
@michael-doubez michael-doubez linked a pull request Dec 28, 2022 that will close this issue
5 tasks
@michael-doubez
Copy link
Contributor

@rlee-metrodigital & @ivankorn Version 2.4 of the plugin is configurable - the default being not to send scopes in token request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants