Breaking build termination on latest Jenkins

[hach-que]

I have the latest Jenkins, and at some point Periodic Reincarnation broke on a new version of Jenkins. Now when my builds finish, they end up in states like this, where they're technically finished, but still holding the slot on the slaves open:

^ The spinner is still going, even though the main build page doesn't show the build as "building".

The logs show this error:

A thread (PeriodicReincarnation thread/2813) died unexpectedly due to an uncaught exception, this may leave your Jenkins in a bad way and is usually indicative of a bug in the code.
java.lang.ClassCastException: org.jenkinsci.plugins.workflow.job.WorkflowJob cannot be cast to hudson.model.AbstractProject
	at org.jenkinsci.plugins.periodicreincarnation.PeriodicReincarnation.checkProject(PeriodicReincarnation.java:325)
	at org.jenkinsci.plugins.periodicreincarnation.PeriodicReincarnation.checkFolder(PeriodicReincarnation.java:353)
	at org.jenkinsci.plugins.periodicreincarnation.PeriodicReincarnation.addProjectsFoundByPeriodicTriggerHit(PeriodicReincarnation.java:315)
	at org.jenkinsci.plugins.periodicreincarnation.PeriodicReincarnation.execute(PeriodicReincarnation.java:115)
	at hudson.model.AsyncPeriodicWork$1.run(AsyncPeriodicWork.java:101)
	at java.lang.Thread.run(Thread.java:748)

[hach-que]

Confirmed uninstalling 1.11 version of this plugin resolves the hanging builds issue.

[hach-que]

Downgrading to 1.10 also resolves the issue, so it looks like this is just a problem with version 1.11.

[Jochen-A-Fuerbacher]

Thanks for reporting this issue. I fixed the error of the log you provided. We could not reproduce the problem with the "hanging builds". So I'm not quite sure, if this fix resolves your issue. I'll release a new version soon. Please comment here if the problem is resolved or not.

[hach-que]

That seems to have fixed the issue for me.

[krulls]

relates to https://issues.jenkins-ci.org/browse/JENKINS-46419

[hach-que]

I'm seeing this issue again on 1.12, now with a different stack trace:

A thread (PeriodicReincarnation thread/40206) died unexpectedly due to an uncaught exception, this may leave your Jenkins in a bad way and is usually indicative of a bug in the code.
java.lang.ClassCastException: org.jenkinsci.plugins.workflow.job.WorkflowJob cannot be cast to hudson.model.AbstractProject
	at org.jenkinsci.plugins.periodicreincarnation.PeriodicReincarnation.checkProject(PeriodicReincarnation.java:400)
	at org.jenkinsci.plugins.periodicreincarnation.PeriodicReincarnation.checkFolder(PeriodicReincarnation.java:393)
	at org.jenkinsci.plugins.periodicreincarnation.PeriodicReincarnation.addUnchangedProjects(PeriodicReincarnation.java:374)
	at org.jenkinsci.plugins.periodicreincarnation.PeriodicReincarnation.execute(PeriodicReincarnation.java:117)
	at hudson.model.AsyncPeriodicWork$1.run(AsyncPeriodicWork.java:101)
	at java.lang.Thread.run(Thread.java:748)

[hach-que]

(Again it's causing a build to not terminate correctly)

[Jochen-A-Fuerbacher]

Thanks for reporting. Should be fixed in 1.12.1. Again, please report any issue. Thank you.