Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split CLI to subcommands (and migrate to picocli) #237

Open
oleg-nenashev opened this issue Dec 6, 2020 · 3 comments · May be fixed by #376
Open

Split CLI to subcommands (and migrate to picocli) #237

oleg-nenashev opened this issue Dec 6, 2020 · 3 comments · May be fixed by #376

Comments

@oleg-nenashev
Copy link
Member

Plugin Installation Manager Tool implements multiple commands at the moment, and options are a bit confusing. The tool would benefit from sub-commands (install-plugins, list-updates) that could simplify the interface for users and allow to easily extend it going forward.

Such a migration would also allow using Plugin Installation Manager as a subcommand on its own, e.g. inside Jenkinsfile Runner CLI which needs plugin management.

FTR https://groups.google.com/g/jenkinsci-dev/c/jTkOpdZ7z1s for the discussion. Reference migration: jenkinsci/jenkinsfile-runner#432

@oleg-nenashev
Copy link
Member Author

@timja @stopalopa @jetersen I have started a PoC for this change: #376 Will try to finalize it for reviews in a few days. Are we all onboard with a breaking change and Plugin Installation Manager 3.0?

@jetersen
Copy link
Member

I am okay with breaking change especially because it allows for easier integration of new features.

@timja
Copy link
Member

timja commented Oct 21, 2021

Breaking changes are fine here, ideally have an upgrade guide / command map table though.

I would just include in PR and release notes, maybe README can link to it (not a huge fan of leaving huge upgrade guides in READMEs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants