New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(GHA) use `gh` CLI to publish artefact to release #578

Merged

timja merged 1 commit into jenkinsci:master from dduportal:patch-1

Jul 11, 2023

Contributor

dduportal commented Jul 11, 2023 •

edited

This PR is a response to #577

It uses the gh CLI to upload artefact to the freshly published GitHub release instead of using a GitHub actions.

The reasons are:

https://github.com/actions/upload-release-asset is archived (causing Release 2.12.12 incomplete (JAR file not published) #577)
There are no more certified action that upload files (only 3rd party)
The gh CLI is pre-installed iun the GitHub runners

Testing done

Not really tested as it is a release process 😅

It's been directly written from the reference doc at https://cli.github.com/manual/gh_release_upload

Submitter checklist

Beta Give feedback

Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!

Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
Options
Successfully updated the issue's project

There was an error updating the issue's project
Ensure that the pull request title represents the desired changelog entry

Ensure that the pull request title represents the desired changelog entry
Options
Successfully updated the issue's project

There was an error updating the issue's project
Please describe what you did

Please describe what you did
Options
Successfully updated the issue's project

There was an error updating the issue's project
Link to relevant issues in GitHub or Jira

Link to relevant issues in GitHub or Jira
Options
Successfully updated the issue's project

There was an error updating the issue's project
Options


          chore(GHA) use gh CLI to publish artefact to release

f8faedb

dduportal marked this pull request as ready for review

July 11, 2023 06:41

dduportal mentioned this pull request

Release 2.12.12 incomplete (JAR file not published) #577

Closed

timja approved these changes

View reviewed changes

timja added the bug label

timja merged commit ac02861 into jenkinsci:master

14 checks passed

dduportal deleted the patch-1 branch

July 11, 2023 07:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment