Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] using the cached values is configurable #17

Closed
NoevilMe opened this issue Oct 15, 2020 · 6 comments · Fixed by #29
Closed

[FEATURE] using the cached values is configurable #17

NoevilMe opened this issue Oct 15, 2020 · 6 comments · Fixed by #29
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@NoevilMe
Copy link

Is your feature request related to a problem? Please describe.
Actually, I need the latest rest api response in every build job. Not a cached value.
I think it's better to provide an option.

Describe the solution you'd like
A checkbox in configure page.

Describe alternatives you've considered
If the checkbox is checked, use the cached values, or retrieve values every time.

Additional context
None

@NoevilMe NoevilMe added the enhancement New feature or request label Oct 15, 2020
@h1dden-da3m0n
Copy link
Contributor

Hi there, and thank you for the feature request!
TBH I was playing with the thought of adding this, even before 1.0. It would even be neatly supported by OKHttp, so I would not have to write much custom code. (unfortunately for that OKHttp needs a folder/file location on the host and I am unsure how to handle that from a Jenkins plugin perspective yet)

Regarless, I'll be a bit busy in the next couple of weeks, so unsure when I have time to work on this. If you yourself or anyone passing by wants to start earlier you are welcome to do so (just post here that u are working on it).
Otherwise, best I can do for now is to state that I will investigate once I find the time and label this as "soon:tm:".

@NoevilMe
Copy link
Author

Thanks for your quick reply. I'm not familiar with java code and jenkins plugins development. so I just modified the code and built it locally. But I can take a try when I have time.

@h1dden-da3m0n
Copy link
Contributor

Hey, Noevi. Feel free to give it a try if you can.
Otherwise, if you don't mind waiting a week or two, I then should have some time again 🤞 .

@h1dden-da3m0n
Copy link
Contributor

h1dden-da3m0n commented Oct 16, 2020

Small update:
I found out how I could handle the file requirement for OkHttp's own builtin caching to work (thanks to the custom-folder-icon-plugin 😁 ).
Sadly I am pretty brain dead rn so, I'll give this method a try most likely next week, assuming I can fit in the time.
Thank you for offering to jump in 👍 , but unless you want this feature now I think I can fit this in next week (now that I have an idea to go of).

/edit: If you still want to try, pls feel free to! I for sure don't want to block you exploring Jenkins/Java 😉

@NoevilMe
Copy link
Author

It isn't an urgent requirement. Thanks very much.

@h1dden-da3m0n
Copy link
Contributor

h1dden-da3m0n commented Oct 30, 2020

So, caching is live with the 1.2.x release. I hope it works as you had envisioned it and per default it will force web requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants