Full Windows support, decreased network bandwitch usage and labels matched by reggex #11

jaesbit · 2018-06-05T16:22:31Z

Now the execution procedure differs between Unix and Win32 Operating Systems and performs each execution with the native shell.
Each slave has its own label installation cache.
Subversioning by hashing of any script changes between last cached and last configured.
Each predefined setup config are checked individually.
If the slave has installed last setup config version it will avoid following executions.
If slave fails in some setup, will not restart all previous executions.
Do not copy files if they were previously copied (using subversioning).
Labels are now matched as a unique label like last versions but now, included regex support.
A lot of code review, comments and JavaDoc updating

Updated to 1.11.2 rev.

Increased rev, now 1.11.3

…e. Stashed to continue tomorrow

…network traffic while we dont know which components are pendind to Setup on connecting nodes.

… added hash attribute.

…ethods. Remote path handling from master, added to launcher. Config file excluding components to avoid useless pre-executions on node connections. On development.

Update pom to add me as developer

Updated .gitignore

* jenkins increased version to 3.4 from 1.442 * maven increased version to 2.5.3 from 2.2.2 * Java builds with JDK 8 * Update Properties section with new rules * Move me and Mikel to contributors section [¡!] Check it that clone can be compiled by default. Removed .factorypath and added to gitignore

Fixed checks for existing installations.

Added more verbose when setDebug(true) First steps to complete tasks Rewrite copyFiles from setupDeployer

Change version delimiter from 3 chars to 1 Updated Deprecated call on listener Components do entire flow, one per one, but, needs to have some checks. I checked and fixed tipical errors and mistakes. Increase in 1 revision for alpha versioncode

Add new code comments

Update code comment Upgraded newDeploy to be dinamically and not store nothing Updated verbose data Added at end Clearing Temporally folder Better error handling by throwing to Jenkins in most cases

Remove unused methods

Fixed executeOnMaster, removed unused arguments Recovered feature to getAllActiveSlaves Added executeOnSlave to easy usages Updated Config events to support new changes English corrections in comments Removed unused imports

Adding more debug messages Create singleSetup in order to handle deployOnSave feature Fixed ignore save_now check SaveNow redirected to doSetup Improved Close stream, only if had something.

Add Not CaseSensitive at label matching

peppelan · 2018-06-05T18:55:41Z

@atgiovannini thanks for the contribution, very appreciated, for both the long-awaited new feature and the housekeeping.

I will review and let you know asap - I'll try to make it by the end of this week if this works for you

jaesbit · 2018-06-06T08:15:29Z

Nice, I'm glad to hear that. I'll wait for merge.

VSCode format document

peppelan · 2018-08-20T06:41:02Z

src/main/java/org/jenkinsci/plugins/slave_setup/ComputerListenerImpl.java

@@ -6,51 +6,46 @@
 import hudson.model.TaskListener;
 import hudson.remoting.Channel;
 import hudson.slaves.ComputerListener;
+// import jenkins.model.Jenkins;


Is there a reason for keeping this?

peppelan · 2018-08-20T06:42:19Z

src/main/java/org/jenkinsci/plugins/slave_setup/ComputerListenerImpl.java

+    public void preOnline(Computer c, Channel channel, FilePath root, TaskListener listener)
+            throws IOException, InterruptedException {
+
+        // Componentes printer will print only debug messages.


Maybe a typo here?

In the future, I wan to add in global config a checkbox for enable/disable debug info.

peppelan · 2018-08-20T06:44:24Z

src/main/java/org/jenkinsci/plugins/slave_setup/SetupConfigItem.java

@@ -91,7 +83,7 @@ public String getPrepareScript() {
    /**
     * Sets the prepare script code
     *
-     * @param prepareScript
+     * @param prepareScript User values


not sure this change improves the reader's understanding

peppelan · 2018-08-20T06:44:28Z

src/main/java/org/jenkinsci/plugins/slave_setup/SetupConfigItem.java

@@ -100,7 +92,7 @@ public void setPrepareScript(String prepareScript) {
    /**
     * Returns the directory containing the setup relevant files and sub directories
     *
-     * @return
+     * @return User values


peppelan · 2018-08-20T06:44:40Z

src/main/java/org/jenkinsci/plugins/slave_setup/SetupConfigItem.java

@@ -173,6 +165,8 @@ public void setPrepareScriptExecuted(boolean prepareScriptExecuted) {

    /**
     * Gets the textual representation of the assigned label as it was entered by the user.
+     * 
+     * @return User values


peppelan · 2018-08-20T06:52:41Z

src/test/java/org/jenkinsci/plugins/slave_setup/SetupDeployerTest.java

+    // @Test
+    // public void testDeployToComputers2() {
+
+    //     // TODO: I think this test isn't necesary, we don't copy in multiple slaves


agreed, maybe better removing it

peppelan

Sorry for the extremely late review. Looks good to me, only minor non-functional changes suggested.

As this waited for way too much time, I would make a release out of it without waiting for these.

Updated comments Removed unused import

Removed Commented Code Fixed Jenkins.MasterComputer null in tests

Simplify slave rootPath for Components Constructor

nvasion · 2018-10-22T23:32:43Z

Anything going on with this merge? I could really use this feature.

Thank you.

peppelan · 2018-10-23T06:35:06Z

Hey, I missed the new commits fixing the CI.
Good to go!

jenkinsci#11 was merged 5 years ago but only released in 1.15 Feb 2023. That change included a cleanup step that removes specifically named files from the /tmp folder using a Linux specific find command. There is not enough benefit from that cleanup step to justify the loss of portability to other Unix systems like FreeBSD, OpenBSD, macOS, and Solaris. https://issues.jenkins.io/browse/JENKINS-70622 reported the issue on Solaris, AIX, and HP variants of Unix.

#11 was merged 5 years ago but only released in 1.15 Feb 2023. That change included a cleanup step that removes specifically named files from the /tmp folder using a Linux specific find command. There is not enough benefit from that cleanup step to justify the loss of portability to other Unix systems like FreeBSD, OpenBSD, macOS, and Solaris. https://issues.jenkins.io/browse/JENKINS-70622 reported the issue on Solaris, AIX, and HP variants of Unix.

Mikel Royo and others added 30 commits May 24, 2018 17:39

Added Unix and Win32 Platform Handling

e9acb7f

Comment&Explanation

6f465d2

Fixed Windows Slaves Support.

e246937

Retrieving verbose script prints during execution.

7825333

Slave logs reducing Noise

33bab88

Updated to 1.11.2 rev.

Retrieved some verbose prints

d8e0546

Increased rev, now 1.11.3

Found possible solution to operate on remote nodes before beeing aliv…

ac6b3b2

…e. Stashed to continue tomorrow

Retrieved the PreLaunch execution events and code in order to reduce …

a7b98ba

…network traffic while we dont know which components are pendind to Setup on connecting nodes.

Added script version control to differ Master-Slave versions with new…

b7b0186

… added hash attribute.

label regex support

1edd313

Adding remote config file handling on remote nodes during preOnline m…

41b45a1

…ethods. Remote path handling from master, added to launcher. Config file excluding components to avoid useless pre-executions on node connections. On development.

Add .gitignore and rules some ignore rules

be31654

Update pom to add me as developer

merged

94d1051

Update gitignore

8c7752e

Remove unnecesary files like .settings folder

b4d5a42

Updated .gitignore

Remove unused files in scm

6304941

Update versions references for maven resources

8eb370e

Updated script to clean and build it.

5608c49

Auto deploy under dev machines (updates build command)

cb34df9

added jenkins master updater script

b0aa798

Update print messages

42cd0ac

Fixed checks for existing installations.

Fixed remotePath overwrited to configFile

144d814

Added more verbose when setDebug(true) First steps to complete tasks Rewrite copyFiles from setupDeployer

Include SetupDeployer

67e8143

Fixed configFile tries to write under folder

9509602

Remove useless comments, cleared code.

dd1d8ad

Cleared code and removed unused coments

55adcb2

Add new code comments

Remove unused imports

3ff326b

Update code comment Upgraded newDeploy to be dinamically and not store nothing Updated verbose data Added at end Clearing Temporally folder Better error handling by throwing to Jenkins in most cases

Code coments correction.

eacc26b

Remove unused methods

jaesbit added 6 commits June 5, 2018 12:54

Remove unused import

d27b95d

Added MultiSlaves executor in Components

bd24b0c

Fixed executeOnMaster, removed unused arguments Recovered feature to getAllActiveSlaves Added executeOnSlave to easy usages Updated Config events to support new changes English corrections in comments Removed unused imports

Updated test to Work with new changes

b2baf0f

Remove debug argument

7bf7205

Fixed bug into newDeploy

961b60f

Adding more debug messages Create singleSetup in order to handle deployOnSave feature Fixed ignore save_now check SaveNow redirected to doSetup Improved Close stream, only if had something.

Javadoc review

fe55fa1

Add Not CaseSensitive at label matching

Fixed non cache update if some setup fails

ba9c1b5

VSCode format document

peppelan reviewed Aug 20, 2018

View reviewed changes

peppelan approved these changes Aug 20, 2018

View reviewed changes

agiovannini and others added 6 commits August 21, 2018 19:01

Removed unnecesary test

0e384fb

Updated comments Removed unused import

Empty string will execute always

2c69e6e

fixed multiosexecutor crash on null EnvVars

f71a3b0

Fixed bad File to use in tests

195d6e2

Removed Commented Code Fixed Jenkins.MasterComputer null in tests

Updated PrepareScript tests to work on windows and Linux

3ce719a

findbugs solved

f24c9ce

Simplify slave rootPath for Components Constructor

peppelan merged commit 2bbf6f1 into jenkinsci:master Oct 23, 2018

MarkEWaite added the enhancement New feature label Feb 12, 2023

MarkEWaite mentioned this pull request Feb 15, 2023

[JENKINS-70622] Do not remove temporary Unix files #24

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Full Windows support, decreased network bandwitch usage and labels matched by reggex #11

Full Windows support, decreased network bandwitch usage and labels matched by reggex #11

jaesbit commented Jun 5, 2018

peppelan commented Jun 5, 2018

jaesbit commented Jun 6, 2018

peppelan Aug 20, 2018

peppelan Aug 20, 2018

jaesbit Aug 21, 2018

peppelan Aug 20, 2018

peppelan Aug 20, 2018

peppelan Aug 20, 2018

peppelan Aug 20, 2018

peppelan left a comment

nvasion commented Oct 22, 2018

peppelan commented Oct 23, 2018

Full Windows support, decreased network bandwitch usage and labels matched by reggex #11

Full Windows support, decreased network bandwitch usage and labels matched by reggex #11

Conversation

jaesbit commented Jun 5, 2018

peppelan commented Jun 5, 2018

jaesbit commented Jun 6, 2018

peppelan Aug 20, 2018

Choose a reason for hiding this comment

peppelan Aug 20, 2018

Choose a reason for hiding this comment

jaesbit Aug 21, 2018

Choose a reason for hiding this comment

peppelan Aug 20, 2018

Choose a reason for hiding this comment

peppelan Aug 20, 2018

Choose a reason for hiding this comment

peppelan Aug 20, 2018

Choose a reason for hiding this comment

peppelan Aug 20, 2018

Choose a reason for hiding this comment

peppelan left a comment

Choose a reason for hiding this comment

nvasion commented Oct 22, 2018

peppelan commented Oct 23, 2018