Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-70622] Do not remove temporary Unix files #24

Merged
merged 1 commit into from Feb 16, 2023

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Feb 15, 2023

[JENKINS-70622] Do not remove temporary files on Unix

#11 was merged 5 years ago but only released in 1.15 Feb 2023. That change includes a cleanup step that removes specifically named files from the /tmp folder using a Linux specific find command. There is not enough benefit from that cleanup step to justify the loss of portability to other Unix systems like macOS and Solaris.

JENKINS-70622 reported the issue on Solaris, AIX, and HP variants of Unix.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

jenkinsci#11 was merged 5 years
ago but only released in 1.15 Feb 2023.  That change included a cleanup
step that removes specifically named files from the /tmp folder using
a Linux specific find command.  There is not enough benefit from that
cleanup step to justify the loss of portability to other Unix systems
like FreeBSD, OpenBSD, macOS, and Solaris.

https://issues.jenkins.io/browse/JENKINS-70622 reported the issue on
Solaris, AIX, and HP variants of Unix.
@MarkEWaite MarkEWaite added the bug Bug fix label Feb 15, 2023
@MarkEWaite MarkEWaite merged commit 3596404 into jenkinsci:master Feb 16, 2023
@MarkEWaite MarkEWaite deleted the remove-jenkins-sh-cleanup branch February 16, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug fix
Projects
None yet
1 participant