Improve exception reporting #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivergondza
commented
Mar 8, 2017
| @@ -801,15 +802,15 @@ private void cleanupConnection(TaskListener listener) { | |||
| * return javaPath if specified in the configuration. | |||
| * Finds local Java, and if none exist, install one. | |||
| */ | |||
| protected String resolveJava(SlaveComputer computer, TaskListener listener) throws InterruptedException, IOException2 { | |||
| protected String resolveJava(SlaveComputer computer, TaskListener listener) throws InterruptedException, IOException { | |||
There was a problem hiding this comment.
Never used in public plugins.
There was a problem hiding this comment.
Also I see no usages in private-source plugins, to which I have access.
But maybe you want to create a new method and use the original one as a wrapper. NIT anyway
There was a problem hiding this comment.
Does not seem to be worth the hassle. Only clients impacted are those that handle IOException2 and IOException differently - which does not really makes sense. Fortunately, this will break source compatibility pointing them to the problem.
olivergondza
commented
Mar 8, 2017
| } catch (IOException e) { | ||
| try { | ||
| // often times error this early means the JVM has died, so let's see if we can capture all stderr | ||
| // and exit code | ||
| throw new IOException2(getSessionOutcomeMessage(session,false),e); | ||
| throw new AbortException(getSessionOutcomeMessage(session,false)); |
There was a problem hiding this comment.
There is no reason to obscure the the friendly cause message with irrelevant stacktrace.
oleg-nenashev
approved these changes
Mar 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.