[FIX JENKINS-44108][JENKINS-44111] Remoting Work Directory Support #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuisathaverat
requested review from
jvz,
dwnusbaum,
oleg-nenashev,
varyvol and
jeffret-b
kuisathaverat
changed the title
kuisathaverat
changed the title
kuisathaverat
removed request for
jvz,
dwnusbaum,
oleg-nenashev,
varyvol and
jeffret-b
jvz
suggested changes
Aug 1, 2018
|
|
||
| /** | ||
| * @param workingDirectory The Working directory set on the configuration of the node. | ||
| * @return <p>the remoting parameter to set the workDir, |
There was a problem hiding this comment.
I'm pretty sure this return tag will include all the lines without needing the <p> wrapper. Otherwise, perhaps it'd be better to put the docs above the tags?
| */ | ||
| @NonNull | ||
| @Restricted(NoExternalUse.class) | ||
| public String getWorkDirParam(@Nonnull String workingDirectory){ |
There was a problem hiding this comment.
You're using two different @Nonnull annotations in the same signature!
| @@ -0,0 +1,5 @@ | |||
| <div> | |||
| In <i>Remoting work directory</i> is an internal data storage, which may be used by Remoting to store caches, logs and other metadata. | |||
There was a problem hiding this comment.
Sentence could make more sense by changing "In" to "The" at the beginning.
jvz
approved these changes
Aug 6, 2018
kuisathaverat
changed the title
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-44108
JENKINS-44111