Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usages of Prototype from Xray #75

Closed
basil opened this issue Jul 18, 2023 · 3 comments
Closed

Remove usages of Prototype from Xray #75

basil opened this issue Jul 18, 2023 · 3 comments

Comments

@basil
Copy link
Member

basil commented Jul 18, 2023

See this blog post for details. Prototype will eventually be removed from Jenkins core, and to prepare for this transition, this plugin must be migrated away from Prototype. The blog post contains instructions on how to find and eliminate usages of Prototype. In this plugin, the following usages of Prototype have been identified. This may not be an exhaustive list:

com/xpandit/plugins/xrayjenkins/model/ServerConfiguration/config.jelly:                                    $fieldCloudHelperWrapper.hide();
com/xpandit/plugins/xrayjenkins/model/ServerConfiguration/config.jelly:                                    $fieldCloudHelperWrapper.show();
com/xpandit/plugins/xrayjenkins/model/ServerConfiguration/config.jelly:                                    $fieldServerHelperWrapper.hide();
com/xpandit/plugins/xrayjenkins/model/ServerConfiguration/config.jelly:                                    $fieldServerHelperWrapper.show();
com/xpandit/plugins/xrayjenkins/model/ServerConfiguration/config.jelly:                                    $fieldWrapper.hide();
com/xpandit/plugins/xrayjenkins/model/ServerConfiguration/config.jelly:                                    $fieldWrapper.show();
com/xpandit/plugins/xrayjenkins/model/ServerConfiguration/config.jelly:                            observeNewInstance.observe(document.querySelector('div[name="serverInstances"]').parentNode, {
com/xpandit/plugins/xrayjenkins/model/ServerConfiguration/config.jelly:                            Q(lastInstanceAdded).on('change',function(e){
com/xpandit/plugins/xrayjenkins/model/ServerConfiguration/config.jelly:                        Q('select[name="hosting"]').on('change',function(e){
com/xpandit/plugins/xrayjenkins/task/XrayExportBuilder/config.jelly:                        $selectParent.hide();
com/xpandit/plugins/xrayjenkins/task/XrayExportBuilder/config.jelly:                        $selectParent.show();
com/xpandit/plugins/xrayjenkins/task/XrayImportBuilder/config.jelly:                    $selectParent.hide();
com/xpandit/plugins/xrayjenkins/task/XrayImportBuilder/config.jelly:                    $selectParent.show();
com/xpandit/plugins/xrayjenkins/task/XrayImportBuilder/config.jelly:                        Q('#selectFormat_${descriptor.defaultBuildID()}').on('change',function(e){
com/xpandit/plugins/xrayjenkins/task/XrayImportBuilder/config.jelly:                        Q('#selectFormat_${descriptor.defaultBuildID()}').on('filled', function(){
com/xpandit/plugins/xrayjenkins/task/XrayImportBuilder/config.jelly:                        Q('#selectInstance_${descriptor.defaultBuildID()}').on('change',function(e){
com/xpandit/plugins/xrayjenkins/task/XrayImportFeatureBuilder/config.jelly:                        $selectParent.hide();
com/xpandit/plugins/xrayjenkins/task/XrayImportFeatureBuilder/config.jelly:                        $selectParent.show();

CC @dmoduarte

@basil
Copy link
Member Author

basil commented Jul 24, 2023

CC @Russell616

@Lima21
Copy link
Collaborator

Lima21 commented Jan 4, 2024

Hi @basil,

I'm Gonçalo Lima, developer of Xray.

Thank you for letting us know that prototype js has been removed from Jenkins.

We've checked the Jenkins 2.426.2 and Xray connector works.

I think the list you share contains false positives. Here is a breakdown of each line you shared in your comment:

serveraddress
serverconfig

Those are JQuery instances. Do you need us to perform other checks?

Best,
Gonçalo Lima

@basil
Copy link
Member Author

basil commented Jan 4, 2024

Thank you for confirming.

@basil basil closed this as not planned Won't fix, can't repro, duplicate, stale Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants