Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment variables are not resolved #19

Closed
k-spa opened this issue Jul 24, 2019 · 2 comments
Closed

Environment variables are not resolved #19

k-spa opened this issue Jul 24, 2019 · 2 comments
Assignees

Comments

@k-spa
Copy link

k-spa commented Jul 24, 2019

Hello,

currently, it seems that the plugin only allows using a fixed value for the stream/topic name (I'm using the "Zulip notification" post-build action, if that matters).

It would be really nice to be able to use environment variables (e.g. $BRANCH_NAME in order to dynamically change where the zulip notification is being posted to.

Thanks!

@butchyyyy
Copy link
Collaborator

Sorry for the late reply, was on vacation.

Since the environments variables are already supported in Zulip Send message, i see no problem supporting them in stream and topic name aswell.

I'll make the changes and roll out new version sometime this week. Will keep you posted.

@butchyyyy butchyyyy self-assigned this Jul 30, 2019
@butchyyyy
Copy link
Collaborator

I just released new version 1.1.0 that now expands jenkins build variables in stream and topic name. The new release should show in the update center in few hours.

Sorry this came later than advocated, I was really swamped with work / family.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants