Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Spanish language #6

Closed
Siva227 opened this issue Aug 30, 2019 · 8 comments
Closed

Support for Spanish language #6

Siva227 opened this issue Aug 30, 2019 · 8 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Siva227
Copy link

Siva227 commented Aug 30, 2019

I used the Negex algorithm to deal with Spanish text. With the help of a Spanish Language expert, a list of negex terms based on the lists provided in the original paper was created. I'd like to contribute those to this repository. To that effect, I've created a fork of this repository. I opened this issue so there could be a discussion as to how this extension can happen.

@jenojp
Copy link
Owner

jenojp commented Aug 30, 2019

Hey, awesome idea! Happy to collaborate on it and make it happen.

@jenojp
Copy link
Owner

jenojp commented Sep 1, 2019

@Siva227 - I pushed a change to the develop branch that should make it cleaner/easier to handle multi language support.
commit

Perhaps you'd like to update your fork and work from here? I believe you already have located Spanish termsets. You can update negspacy/termsets.py with them and then we can add a few test cases.

@Siva227
Copy link
Author

Siva227 commented Sep 1, 2019

Great! I'll add the termsets to negspacy/termsets.py. Just so there's no confusion, these are the tags I used and the corresponding mappings to the tags you're using.

[PREN] - Prenegation rule tag - A term which negates the medical finding that follows it
[POST] - Postnegation rule tag - A term which negates the medical finding that precedes it
[PSEU] - Pseudo negation tag - Not a negation even though it contains a negation term
[CONJ] - Conjunction tag

PREN - Preceeding negations
POST - Following negations
PSEU - Pseudo negations
CONJ - Termination

I'll proceed with these and add necessary test cases.

@jenojp
Copy link
Owner

jenojp commented Sep 2, 2019

Yup I believe that looks right!

@jenojp jenojp added enhancement New feature or request help wanted Extra attention is needed labels Dec 15, 2020
@jenojp
Copy link
Owner

jenojp commented Oct 26, 2021

Closing this issue due to inactivity

@jenojp jenojp closed this as completed Oct 26, 2021
@davidbetancur8
Copy link

Hello! Is there any work on this lately?

@jenojp
Copy link
Owner

jenojp commented Oct 5, 2022

Not that I’m aware of

@jenojp
Copy link
Owner

jenojp commented Mar 25, 2023

Taken care of by #51 . Thanks @j6e !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants