Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReGaHss: Manually running a program should check conditions first #229

Closed
jens-maus opened this issue Jan 2, 2018 · 7 comments
Closed
Labels
🐛 bug-report Something isn't working 🏷️ ReGaHss This refs the ReGaHss component

Comments

@jens-maus
Copy link
Owner

If a program in the WebUI is triggered to be manually executed it immediately executes the 1. then branch instead of walking through all defined conditions and then correctly executes the corresponding then branch or skips execution of a program.

@jens-maus jens-maus added 🐛 bug-report Something isn't working 🏷️ ReGaHss This refs the ReGaHss component labels Jan 2, 2018
@DrTob
Copy link

DrTob commented Jan 2, 2018

It's not a bug, it's a feature. Otherwise you wouldn't be able to run a program manually which normally is triggerd by a button.

@jens-maus
Copy link
Owner Author

Well, it is probably a matter of discussion if this is really a feature because for newby users and ordinary users it probably make no sense that developed conditions are not checked if a program is manually triggered.

@Hypnos3
Copy link
Contributor

Hypnos3 commented Jan 2, 2018

Maybe have two ways to run a program:
the current behaviour "ProgramExecute" and a new one "ProgrammTrigger"

"ProgramExecute" should immediately executes the 1. then branch
"ProgrammTrigger" should walking through all defined conditions and then correctly executes the corresponding then branch or skips execution of a program

@DrTob
Copy link

DrTob commented Jan 2, 2018

I think there’re as many or even more users using programs as my example. (Eg: „all lights off“, „start TV scene“) If you change the behavior, it’s not longer possible to execute this programs manually.

@Baenker
Copy link

Baenker commented Jan 8, 2018

I aggree to DrTob. Please do not change it. For me it‘s a feature

@jp112sdl
Copy link
Contributor

jp112sdl commented Nov 3, 2021

duplicate #1285
can be closed?

@jens-maus
Copy link
Owner Author

Think so, yes. Thx for checking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug-report Something isn't working 🏷️ ReGaHss This refs the ReGaHss component
Projects
None yet
Development

No branches or pull requests

5 participants