Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError in browser by trying to update firmware version of device #770

Closed
floriandrott opened this issue Feb 8, 2020 · 11 comments
Closed
Labels
⚓ upstream issue This is a bug/issue for/in upstream software (OCCU, etc.) 🐛 bug-report Something isn't working 🏷️ WebUI This refs the WebUI component

Comments

@floriandrott
Copy link

Describe the bug
I can't update the version version of my device. The reason is that when I click on 'update' within the WebUI then I get in my browser (Safari) a TypeError error in the console (Safari). I tried this out also in Chrome.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Startseite > Einstellungen > Geräte-Firmware - Übersicht'
  2. Click on 'Update'
  3. Nothing happens
  4. Open developer tool in the browser to see the console
  5. See typeError

Expected behavior
Firmware update is starting.

Screenshots
Bildschirmfoto 2020-02-08 um 11 46 40
Bildschirmfoto 2020-02-08 um 11 46 25

System information (please complete the following information):

  • Version RaspberryMatic 3.49.17.20200131
  • Hardware Proxmox

Additional context
Was also existing in the previous RaspberryMatic version

@jens-maus jens-maus added 🐛 bug-report Something isn't working 🏷️ WebUI This refs the WebUI component ❓ undecided No decision to accept or reject ticket yet labels Feb 8, 2020
@floriandrott
Copy link
Author

Is there a workaround to update the firmware of device? Due to the error I can't update the firmware.

@jens-maus
Copy link
Owner

Please wait until the next coming RaspberryMatic update (or until RaspberryMatic beta versions appear) which will be based on 3.51.6 OCCU which potentially could fix the issue

@jens-maus
Copy link
Owner

@floriandrott I just updated RaspberryMatic to OCCU 3.51.6 today and generated new experimental beta versions. So if you are brave and would like to give it a test so that we can check before the final release that the issue is eiterh solved in 3.51.6 or that we need to fix it ourself, please download the experimental version here: https://github.com/jens-maus/RaspberryMatic/actions/runs/36918297 and let me know if this version solves your issues.

@jens-maus
Copy link
Owner

I just checked the relevant code passage/function that your report is referencing:

isDutyCycleOK4DevUpdate = function() {                                         
  var ifaceBidCosRF = "BidCos-RF";          
  var BidCosIFaces = homematic("Interface.listBidcosInterfaces", {"interface": ifaceBidCosRF});
  var dcVal = 0,                                                          
    dcWarningLevel = 80,                                    
    dcOK = true;                                                                          
                                                                          
  jQuery.each(BidCosIFaces, function (index, iFace) {       
    if (iFace.type == "CCU2") {                                                           
      dcVal = (typeof iFace.dutyCycle != "undefined") ? parseInt(iFace.dutyCycle) : 0;
      if (dcVal >= dcWarningLevel) {                        
        dcOK = false;                                                                     
      }                                                                   
      return false; //leave each loop                       
    }                     
  });                                    
  return dcOK;                       
};                                                                               

For you it seems to crash in the jQuery.each() call. To clarify, can you please tell me if you have any BidCos-RF device and which RF module (RPI-RF-MOD or HM-MOD-RPI-PCB) you are using with RaspberryMatic?!? My guess is that you are not using any RPI-RF-MOD/HM-MOD-RPI-PCB but simply a HmIP-RFUSB which is a HmIP-only RF stick. Is this correct?

@jens-maus jens-maus added ⚓ upstream issue This is a bug/issue for/in upstream software (OCCU, etc.) 🕙 awaiting feedback waiting for feedback from ticket owner labels Feb 10, 2020
@floriandrott
Copy link
Author

Thanks for the quick help. Unfortunately I get an error when I try to update RasperryMatic via the WebUI.
Bildschirmfoto 2020-02-11 um 08 51 22

You are right. I use the HmIP-RFUSB due to the fact that I have only HmIP-only devices.

@no-response no-response bot removed the 🕙 awaiting feedback waiting for feedback from ticket owner label Feb 11, 2020
@jens-maus
Copy link
Owner

Then download the latest 3.51.6 nightly snapshot from here, please:
https://github.com/jens-maus/RaspberryMatic/releases/tag/snapshots

@floriandrott
Copy link
Author

@jens-maus will do. The CI pipeline failed on the OVA build and there is currently no build available.

@jens-maus
Copy link
Owner

@floriandrott Then wait for the next nightly build to appear. I just fixed some issues in the CI piplelines and the next build should hopefully finish correctly.

And if you just use a HmIP-RFUSB I think I know where the issues comes from. Will have to develop a fix for it and let you know as soon as you can test it.

@jens-maus jens-maus removed the ❓ undecided No decision to accept or reject ticket yet label Feb 11, 2020
@jens-maus jens-maus added this to the 3.51.6.20200229 milestone Feb 11, 2020
@jens-maus
Copy link
Owner

As you can see, I just committed a potential fix for your reported issue. So please wait for the next nightly build to appear and retest again if you have a test installation and see if this fixes your WebUI based device update issues.

@floriandrott
Copy link
Author

Thanks @jens-maus - with the new official version it's working!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚓ upstream issue This is a bug/issue for/in upstream software (OCCU, etc.) 🐛 bug-report Something isn't working 🏷️ WebUI This refs the WebUI component
Projects
Development

No branches or pull requests

2 participants