Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft changed the custom timezone identifier string AGAIN #246

Closed
sdetweil opened this issue Jan 17, 2023 · 2 comments · Fixed by #286
Closed

Microsoft changed the custom timezone identifier string AGAIN #246

sdetweil opened this issue Jan 17, 2023 · 2 comments · Fixed by #286

Comments

@sdetweil
Copy link
Contributor

sdetweil commented Jan 17, 2023

the old string was
'tzone://Microsoft/Custom'
now its
'Customized Time Zone'

so, temp fix is to edit ical.,js and change

 if (tz === 'tzone://Microsoft/Custom' ){ 

to

if (tz === 'tzone://Microsoft/Custom' || tz==='Customized Time Zone') {

in two places

@sdetweil
Copy link
Contributor Author

sdetweil commented Jun 1, 2023

and some more..

DTSTART;TZID="(UTC+00:00) Dublin, Edinburgh, Lisbon, London":20230301T060000
DTEND;TZID="(UTC+00:00) Dublin, Edinburgh, Lisbon, London":20230301T120000

they are using the custom timezone definition

BEGIN:VTIMEZONE
TZID:(UTC+00:00) Dublin\, Edinburgh\, Lisbon\, London

@sdetweil
Copy link
Contributor Author

sdetweil commented Nov 15, 2023

I submitted this pull request which fixes both these problems..
#286

@jens-maus jens-maus linked a pull request Nov 22, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant