Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserve whitespace when preprocessing #1

Open
jenseng opened this issue Mar 29, 2015 · 1 comment
Open

preserve whitespace when preprocessing #1

jenseng opened this issue Mar 29, 2015 · 1 comment

Comments

@jenseng
Copy link
Owner

jenseng commented Mar 29, 2015

to facilitate debugging, we should preserve whitespace (or at least newlines) when converting a translate="yes" component to a <ComponentInterpolator> ... that way line numbers will match up with the original source. as it stands right now, recast is injecting some newlines, presumably for readability.

we handle this kinda rudimentarily in i18nliner (erb)

@jenseng
Copy link
Owner Author

jenseng commented May 8, 2015

this is slightly less critical, since we now share the same AST with i18nliner-js ... for i18nliner errors at least, the line numbers will be correct (since it uses the original loc.start)

that said, it's still nice to do for general js debugging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant