Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge wrappers into contained placeholder #5

Closed
jenseng opened this issue Apr 3, 2015 · 1 comment
Closed

merge wrappers into contained placeholder #5

jenseng opened this issue Apr 3, 2015 · 1 comment

Comments

@jenseng
Copy link
Owner

jenseng commented Apr 3, 2015

Spawned from #3

If all that a wrapper contains is a placeholder (no text content), we should not create a wrapper and should instead merge its component(s) into the placeholder value, e.g. consider:

<p translate="yes">Hello <b>{user}</b></p>

Ideally that should yield the following (note the lack of wrapper):

"Hello %{user}"

The value for %{user} would be <b>{user}</b>

@jenseng
Copy link
Owner Author

jenseng commented Apr 6, 2015

upon adding a failing test i realized it actually does this already, except that, the placeholder is poorly named (e.g. <b>{user}</b> => %{b_user}) ... so maybe we just need better inferred placeholders

@jenseng jenseng closed this as completed Apr 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant