Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature wish] [Cosmetics]: Font color #66

Open
goshuberto opened this issue Mar 23, 2024 · 8 comments
Open

[Feature wish] [Cosmetics]: Font color #66

goshuberto opened this issue Mar 23, 2024 · 8 comments

Comments

@goshuberto
Copy link

For older people who have difficulties reading the standard font-size chosen for 400dpi, resp. needing extra glasses for mobile device usage, the color of choice as an additional obstacle.
Form a security point of view tt might be beneficial that it isn't well readable, but I'd highly appreciate if users could adjust the default color - fine to stay monochrome but at least a 'white' option was helpful. It's not about taste/fashion, simply for readability.
Thanks a lot!

@jenspfahl
Copy link
Owner

Which font colors do you mean exactly? The description texts or the input fields or the passwords?

@goshuberto
Copy link
Author

goshuberto commented Mar 28, 2024

Thanks a lot for your attention, and sorry for late replying... busy week here.

Most important was the auto-fill dialog - I can never read the 1st line, where info about the currently chosen/applicable credential is shown. I even hit the "'don' use for this app" option - unintentionally of course.
On my pixel tablet (LCD) everything is readable (light default theme).
On my pixel phone (OLED with default dark theme - keeping due to energy benefits despite disliking it totally) it's even hard to read the app settings menu resp. any text.
Switching to light theme improves on OLED too.
But having an option to switch the font color was highly appreciated (and not very hard to implement hopefully). No need to offer colour palette imho - while not harmful too ;-)

@jenspfahl
Copy link
Owner

That's weird. I also use a Pixel phone (4a) and it looks fine in light and dark mode. Let me check with a few other devices. Maybe it is a GrapheneOS specific problem.

@goshuberto
Copy link
Author

Unfortunately it's my weak eyes :-( Got new glasses and now I can read it better, but compared to all other text on my OLED pixel, it's significant harder for me. As mentioned, I dislike the dark theme, but technology wise, it makes sense, so I keep it - I guess less OLED wearing prolonged lifespan is another benefit...

@MBerkayHamurcu
Copy link

Firstly, thank you very much for developing and maintaining this useful app.

I would like to add to this thread that the choice of font color is also problematic in another case: using the app in dark mode while the phone screen is set to grayscale.
In the following image one can see that for example the password is hard to read:

The second image is another example of the main accent color 0x9f0052 being hard to read in dark mode on a grayscaled screen. The effect is much more pronounced on the phone.:

I know that this is kind of an edge case, but nevertheless worth considering if you were already about to make changes to font colors or adding a manual setting option.
Thank you in advance.

@jenspfahl
Copy link
Owner

@MBerkayHamurcu Thank you for your note. Do you use a Custom ROM? Because i don't and when i set the colors to greyscale all looks fine, i.e. with much more contrast than your screenshot. (I use a Pixel, no Custom ROM).
I'll try to make the colors customable, but it seems not easy. I would have to touch all views and set the colors programatically (instead from the layout xmls).

@jenspfahl
Copy link
Owner

There is also an option in the settings of the app to display the passwords in monochrome, maybe the helps for grey scaled displays?

Also I want to point out that most Android systems have a setting to adjust general font sizes used in all apps and even increase color contrast. I hope that helps instead of supporting a custom color on the app, which is eventually cumbersome to implement.

@MBerkayHamurcu
Copy link

I am using a Samsung Galaxy S20 FE without a custom ROM (One UI 5.1, Android 13) in the so-called sleep mode, which activates the grayscale filter, among other things.
Okay, I wasn't aware of that as I haven't really developed Android apps yet. I will try the settings you mentioned.

Many thanks and all the best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants