Skip to content
This repository has been archived by the owner on Mar 16, 2020. It is now read-only.

Filter #64

Closed
sboddeus opened this issue Jan 17, 2018 · 3 comments
Closed

Filter #64

sboddeus opened this issue Jan 17, 2018 · 3 comments

Comments

@sboddeus
Copy link
Contributor

Is there a reason other than lack of resources for not including filter on observables?
I would be happy to add a pull request unless I am missing a particular design decision.

@JensRavens
Copy link
Owner

The main reason so far is that I haven't had the need for it.

observable.subscribe {
  if condition {
    doWhatYouWant()
  }
}

But it makes sense to include it in Observables directly (especially for mapping and chaining reasons). So if you want to go for it, PRs are welcome! :)

@sboddeus
Copy link
Contributor Author

Here is my suggested implementation PR: #65

@JensRavens
Copy link
Owner

Closed by PR #65

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants