Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builder timeout should be in milliseconds #2460

Closed
gayathma3 opened this issue Nov 9, 2022 · 0 comments · Fixed by #2461
Closed

Builder timeout should be in milliseconds #2460

gayathma3 opened this issue Nov 9, 2022 · 0 comments · Fixed by #2461

Comments

@gayathma3
Copy link

Description:

In src/Query/Builder.php line number 158, the time-out value should be in milliseconds but it's defined as seconds.

  /**
     * Set the cursor timeout in seconds.
     * @param int $seconds
     * @return $this
     */
    public function timeout($seconds)
    {
        // $this->timeout = $seconds; 
          $this->timeout = $seconds * 1000; // because on line 383, it's $options['maxTimeMS'] = $this->timeout;

        return $this;
    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant