Use single connection using DSN for testing #2462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 87.89% // Head: 87.83% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2462 +/- ##
============================================
- Coverage 87.89% 87.83% -0.07%
Complexity 677 677
============================================
Files 31 31
Lines 1553 1553
============================================
- Hits 1365 1364 -1
- Misses 188 189 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
alcaeus
added a commit
to alcaeus/laravel-mongodb
that referenced
this pull request
Nov 14, 2022
Squashed commit of the following: commit 6f6f78a Author: Andreas Braun <git@alcaeus.org> Date: Fri Nov 11 09:07:08 2022 +0100 Add missing test for code coverage commit e4b0aca Author: Andreas Braun <git@alcaeus.org> Date: Fri Nov 11 08:58:37 2022 +0100 Apply StyleCI fixes commit 911acf3 Author: Andreas Braun <git@alcaeus.org> Date: Fri Nov 11 08:32:22 2022 +0100 Use matrix config instead of manually specifying builds commit be0d449 Author: Andreas Braun <git@alcaeus.org> Date: Fri Nov 11 08:29:53 2022 +0100 Update wordings commit d3d894a Author: Andreas Braun <git@alcaeus.org> Date: Fri Nov 11 08:29:35 2022 +0100 Document DSN configuration as preferred configuration method commit 2809d43 Author: Andreas Braun <git@alcaeus.org> Date: Fri Nov 11 08:28:38 2022 +0100 Always use connection string in tests
Merged
divine
approved these changes
Nov 14, 2022
divine
added a commit
that referenced
this pull request
Jan 16, 2023
commit 551ec9f Author: Henrique Troiano <63327237+henriquetroiano@users.noreply.github.com> Date: Sun Jan 15 20:19:33 2023 -0300 Add Geonear instructions to ReadMe. Closes #1878 (#2487) * create aggregate geonear instructions * create aggregate geonear instructions * create aggregate geonear instructions * create aggregate geonear instructions * create aggregate geonear instructions * chore: revert back readme changes * chore: minor readme change Co-authored-by: henriquetroiano <henriquetroiano@hoomweb.com> Co-authored-by: divine <48183131+divine@users.noreply.github.com> commit 317f702 Author: Hikmat <hikmet.hesenov.93@gmail.com> Date: Sun Jan 15 04:58:12 2023 -0800 fix: whereBelongsTo (#2454) * override getQualifiedForeignKeyName() and add tests for whereBelongsTo * delete unneeded query() call * type hint for getQualifiedForeignKeyName() Co-authored-by: Hikmat Hasanov <hikmet.hasanov@proton.me> commit e5e9193 Author: Andreas Braun <alcaeus@users.noreply.github.com> Date: Sun Nov 27 19:32:25 2022 +0100 Transaction support (#2465) * Add support for transactions Co-authored-by: klinson <klinson@163.com> Co-authored-by: levon80999 <levonb@ucraft.com> * Start single-member replica set in CI Co-authored-by: levon80999 <levonb@ucraft.com> * Add connection options for faster failures in tests The faster connection and server selection timeouts ensure we don't spend too much time waiting for the inevitable as we're expecting fast connections on CI systems Co-authored-by: levon80999 <levonb@ucraft.com> * Apply readme code review suggestions * Simplify replica set creation in CI * Apply feedback from code review * Update naming of database env variable in tests * Use default argument for server selection (which defaults to primary) * Revert "Simplify replica set creation in CI" This partially reverts commit 203160e. The simplified call unfortunately breaks tests. * Pass connection instance to transactional closure This is consistent with the behaviour of the original ManagesTransactions concern. * Correctly re-throw exception when callback attempts have been exceeded. * Limit transaction lifetime to 5 seconds This ensures that hung transactions don't block any subsequent operations for an unnecessary period of time. * Add build step to print MongoDB server status * Update src/Concerns/ManagesTransactions.php Co-authored-by: Jeremy Mikola <jmikola@gmail.com> Co-authored-by: klinson <klinson@163.com> Co-authored-by: levon80999 <levonb@ucraft.com> Co-authored-by: Jeremy Mikola <jmikola@gmail.com> commit 0606fc0 Author: Andreas Braun <alcaeus@users.noreply.github.com> Date: Mon Nov 14 12:51:00 2022 +0100 Use single connection using DSN for testing (#2462) * Always use connection string in tests * Document DSN configuration as preferred configuration method * Update wordings * Use matrix config instead of manually specifying builds * Apply StyleCI fixes * Add missing test for code coverage commit 560e05e Author: Andreas Braun <alcaeus@users.noreply.github.com> Date: Mon Nov 14 12:46:55 2022 +0100 Chore: add types where safe (#2464) * Use direct method calls over call_user_func_array * Add return types where safely possible * Fix styleCI issues commit dbde512 Author: Andreas Braun <alcaeus@users.noreply.github.com> Date: Thu Nov 10 13:55:56 2022 +0100 Pass timeout in milliseconds (#2461) commit 42e0100 Author: abofazl rasoli <75317352+abolfazl-rasoli@users.noreply.github.com> Date: Fri Nov 4 16:18:52 2022 +0330 chore: test firstOrCreate method for the model (#2399) commit 61cc6ed Author: Stas <smolevich90@gmail.com> Date: Thu Sep 1 16:20:31 2022 +0300 Add info about new release 3.9.2 (#2440) * Add info about new release 3.9.2 * chore: update changelog Co-authored-by: Divine <48183131+divine@users.noreply.github.com> commit 5bcc82e Merge: 41a9c97 f670c5f Author: Stas <smolevich90@gmail.com> Date: Thu Sep 1 12:58:26 2022 +0300 Merge pull request #2420 from apeisa/fix/stringable-sort [3.9] Fix/stringable sort commit 41a9c97 Merge: ad4422a c27924c Author: Stas <smolevich90@gmail.com> Date: Thu Sep 1 12:55:15 2022 +0300 Merge pull request #2438 from RosemaryOrchard/pr/2394 [3.9] Respect Laravel 9's single word name mutators commit c27924c Author: Rosemary Orchard <contact@rosemaryorchard.com> Date: Thu Aug 25 17:11:29 2022 +0100 Add tests for the mutator commit 55e80a2 Merge: 6b11977 9b3ffc2 Author: Rosemary Orchard <contact@rosemaryorchard.com> Date: Thu Aug 25 14:35:46 2022 +0100 Merge branch 'pr/2394' of github.com:RosemaryOrchard/laravel-mongodb into pr/2394 commit 6b11977 Author: Rosemary Orchard <contact@rosemaryorchard.com> Date: Thu Aug 25 14:17:58 2022 +0100 Fix formatting More CS-Fixer formatting, unrelated to the PR PSR2?! commit 9b3ffc2 Merge: e5a8272 ad4422a Author: Rosemary Orchard <16113535+RosemaryOrchard@users.noreply.github.com> Date: Thu Aug 25 14:32:21 2022 +0100 Merge branch 'jenssegers:master' into pr/2394 commit e5a8272 Author: Rosemary Orchard <contact@rosemaryorchard.com> Date: Thu Aug 25 14:25:57 2022 +0100 PSR2?! commit 79fad0e Author: Rosemary Orchard <contact@rosemaryorchard.com> Date: Thu Aug 25 14:22:46 2022 +0100 More CS-Fixer formatting, unrelated to the PR commit ce693a8 Author: Rosemary Orchard <contact@rosemaryorchard.com> Date: Thu Aug 25 14:17:58 2022 +0100 Fix formatting commit f670c5f Author: Antti Peisa <antti.peisa@gmail.com> Date: Mon Jul 25 13:59:05 2022 +0300 Update tests/QueryTest.php Co-authored-by: Divine <48183131+divine@users.noreply.github.com> commit f7895bc Author: Antti Peisa <antti.peisa@gmail.com> Date: Mon Jul 25 13:58:59 2022 +0300 Update tests/QueryTest.php Co-authored-by: Divine <48183131+divine@users.noreply.github.com> commit 3a87b28 Author: Antti Peisa <antti.peisa@gmail.com> Date: Sat Jul 16 13:02:38 2022 +0300 style code fixes pt. 3 commit ed86610 Author: Antti Peisa <antti.peisa@gmail.com> Date: Sat Jul 16 12:55:21 2022 +0300 make the stringable object type safe commit 50221ef Author: Antti Peisa <antti.peisa@gmail.com> Date: Sat Jul 16 12:53:31 2022 +0300 style code fixes pt. 2 commit 496f8a0 Author: Antti Peisa <antti.peisa@gmail.com> Date: Sat Jul 16 12:52:29 2022 +0300 style code fixes commit f6c9678 Author: Antti Peisa <antti.peisa@gmail.com> Date: Sat Jul 16 12:50:09 2022 +0300 support stringable objects when sorting commit ad4422a Merge: f4c448f fc67e04 Author: Stas <smolevich90@gmail.com> Date: Wed Jun 29 22:04:13 2022 +0300 Merge pull request #2365 from jenssegers/update-changelog chore: update changelog and prepare release commit 5d292a2 Author: Pavel Borunov <8665691+mrneatly@users.noreply.github.com> Date: Sat May 28 09:57:03 2022 +0300 Respect new Laravel accessors's approach Fix getting a value from a one-word `\Illuminate\Database\Eloquent\Casts\Attribute`-returning accessors commit fc67e04 Author: divine <48183131+divine@users.noreply.github.com> Date: Fri Mar 11 04:14:08 2022 +0300 chore: update changelog and prepare release commit f4c448f Author: Divine <48183131+divine@users.noreply.github.com> Date: Mon Mar 7 23:07:22 2022 +0300 feat: backport support for cursor pagination (#2362) Backport #2358 to L9 Co-Authored-By: Jeroen van de Weerd <info@jeroenvdweerd.nl> commit 8d601b2 Author: Rob Brain <robjbrain@gmail.com> Date: Wed Mar 2 03:45:43 2022 +0700 Check if failed log storage is disabled in Queue Service Provider (#2357) * fix: check if failed log storage is disabled in Queue Service Provider Co-authored-by: divine <48183131+divine@users.noreply.github.com> commit 1e49c5e Merge: 6cdd309 b6a76f9 Author: Jens Segers <segers.jens@gmail.com> Date: Thu Feb 17 11:00:31 2022 +0100 Merge pull request #2344 from divine/l9 feat: initial laravel 9 compatibility commit b6a76f9 Author: divine <48183131+divine@users.noreply.github.com> Date: Wed Feb 9 05:03:48 2022 +0300 fix: apply php-cs-fixer result commit 20b9d0e Author: divine <48183131+divine@users.noreply.github.com> Date: Wed Feb 9 04:30:38 2022 +0300 fix: small php-doc comment commit 8b4c6dc Author: divine <48183131+divine@users.noreply.github.com> Date: Wed Feb 9 04:26:20 2022 +0300 fix: apply php-cs-fixer results commit 40846ab Author: divine <48183131+divine@users.noreply.github.com> Date: Wed Feb 9 04:22:39 2022 +0300 fix: imrprove php-doc comments commit 42c1ff2 Author: divine <48183131+divine@users.noreply.github.com> Date: Wed Feb 9 04:04:43 2022 +0300 feat: update php-cs-fixer & docker php version commit 9c2b001 Author: divine <48183131+divine@users.noreply.github.com> Date: Wed Feb 9 03:59:33 2022 +0300 feat: use stable laravel release commit d02a46c Author: divine <48183131+divine@users.noreply.github.com> Date: Sun Feb 6 05:40:20 2022 +0300 feat: initial laravel 9 compatibility commit 6cdd309 Merge: 6aa6ad1 39f940d Author: Stas <smolevich90@gmail.com> Date: Wed Feb 2 02:35:36 2022 +0300 Merge pull request #2341 from divine/update-changelog [3.8] Update changelog commit 39f940d Author: divine <48183131+divine@users.noreply.github.com> Date: Tue Feb 1 03:43:56 2022 +0300 chore: add missing dots to readme. commit 2322a78 Author: divine <48183131+divine@users.noreply.github.com> Date: Tue Feb 1 03:42:44 2022 +0300 chore: update changelog
aptcreativedesign
added a commit
to ridown/laravel-mongodb
that referenced
this pull request
Feb 14, 2023
…into develop * 'master' of https://github.com/jenssegers/laravel-mongodb: (98 commits) Report package version when establishing connection (mongodb#2507) Add missing return types Fix styleCI issues Fix auth test for Laravel 10 Update tested PHP versions Remove dependency on doctrine/dbal Rename getBaseQuery method to toBase Remove deprecated PHPUnit call Update handling of dates for Laravel 10 chore: disable php 8.0 in gh builds chore: update minimum stability Bump dependencies for Laravel 10 fix: keep camel cased name except for `getMorphs` tests: for snake case morph relation name Add Geonear instructions to ReadMe. Closes mongodb#1878 (mongodb#2487) fix: whereBelongsTo (mongodb#2454) Transaction support (mongodb#2465) Use single connection using DSN for testing (mongodb#2462) Chore: add types where safe (mongodb#2464) Pass timeout in milliseconds (mongodb#2461) ... # Conflicts: # composer.json # src/Eloquent/Builder.php # src/Eloquent/Model.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the connection configuration for tests to always use a connection string (DSN) in the main connection. To offset the other connections, a new test for the connection class was added testing various configurations to ensure that non-DSN functionality is properly unit tested. This reduces the workload around adding transactions (as that will introduce testing on different topologies).
To compound this change, I updated the readme to document the connection string as the primary method for configuring a connection. Using host/port separately is discouraged, and with hosted platforms (like MongoDB Atlas) only providing a connection string I think it's preferable to document this first. This configuration method is also more intuitive when connecting to a replica set.
The build pipeline was added to leverage the matrix structure instead of defining builds manually. No changes in the tested versions have been made - I'll do those in a separate pull request.