Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: morphTo when relation name is in camel case #2498

Merged
merged 2 commits into from
Jan 16, 2023
Merged

fix: morphTo when relation name is in camel case #2498

merged 2 commits into from
Jan 16, 2023

Conversation

divine
Copy link
Contributor

@divine divine commented Jan 16, 2023

Recreating #2318 as I don't have permission to resolve merge conflicts.

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2023

Codecov Report

Base: 88.12% // Head: 88.18% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (db72c17) compared to base (6aa6ad1).
Patch coverage: 89.43% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2498      +/-   ##
============================================
+ Coverage     88.12%   88.18%   +0.06%     
- Complexity      664      697      +33     
============================================
  Files            33       32       -1     
  Lines          1566     1701     +135     
============================================
+ Hits           1380     1500     +120     
- Misses          186      201      +15     
Impacted Files Coverage Δ
src/Auth/PasswordResetServiceProvider.php 33.33% <ø> (ø)
src/Eloquent/EmbedsRelations.php 100.00% <ø> (ø)
src/Helpers/QueriesRelationships.php 91.37% <ø> (-1.85%) ⬇️
src/Queue/Failed/MongoFailedJobProvider.php 21.05% <ø> (ø)
src/Queue/MongoConnector.php 100.00% <ø> (ø)
src/Queue/MongoJob.php 100.00% <ø> (ø)
src/Queue/MongoQueue.php 100.00% <ø> (ø)
src/Relations/BelongsToMany.php 86.53% <ø> (+0.39%) ⬆️
src/Relations/EmbedsOne.php 95.45% <ø> (ø)
src/Relations/EmbedsOneOrMany.php 98.14% <ø> (ø)
... and 29 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Smolevich Smolevich merged commit 098347c into master Jan 16, 2023
@alcaeus alcaeus deleted the pr_2318 branch September 6, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants