Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report package version when establishing connection #2507

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Feb 9, 2023

This adds this package name to the driver info, which is reported as part of the driver handshake metadata. Server administrators can use this to get information on connecting applications and their drivers.

@codecov-commenter
Copy link

Codecov Report

Base: 88.18% // Head: 88.25% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (d7fef9d) compared to base (098347c).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2507      +/-   ##
============================================
+ Coverage     88.18%   88.25%   +0.07%     
- Complexity      697      701       +4     
============================================
  Files            32       32              
  Lines          1701     1712      +11     
============================================
+ Hits           1500     1511      +11     
  Misses          201      201              
Impacted Files Coverage Δ
src/Connection.php 89.02% <100.00%> (+1.70%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alcaeus alcaeus requested a review from divine February 10, 2023 12:50
@divine divine merged commit 0b03010 into mongodb:master Feb 10, 2023
@alcaeus alcaeus deleted the report-package-version branch February 10, 2023 13:22
aptcreativedesign added a commit to ridown/laravel-mongodb that referenced this pull request Feb 14, 2023
…into develop

* 'master' of https://github.com/jenssegers/laravel-mongodb: (98 commits)
  Report package version when establishing connection (mongodb#2507)
  Add missing return types
  Fix styleCI issues
  Fix auth test for Laravel 10
  Update tested PHP versions
  Remove dependency on doctrine/dbal
  Rename getBaseQuery method to toBase
  Remove deprecated PHPUnit call
  Update handling of dates for Laravel 10
  chore: disable php 8.0 in gh builds
  chore: update minimum stability
  Bump dependencies for Laravel 10
  fix: keep camel cased name except for `getMorphs`
  tests: for snake case morph relation name
  Add Geonear instructions to ReadMe. Closes mongodb#1878 (mongodb#2487)
  fix: whereBelongsTo (mongodb#2454)
  Transaction support (mongodb#2465)
  Use single connection using DSN for testing (mongodb#2462)
  Chore: add types where safe (mongodb#2464)
  Pass timeout in milliseconds (mongodb#2461)
  ...

# Conflicts:
#	composer.json
#	src/Eloquent/Builder.php
#	src/Eloquent/Model.php
@divine
Copy link
Contributor

divine commented Jul 28, 2023

Hello @alcaeus @jmikola @GromNaN,

We probably could push this PR to another branches as well to see the usage for older versions. Just an idea.

Thanks!

@alcaeus
Copy link
Member Author

alcaeus commented Jul 28, 2023

That sounds good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants