Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.9] Use correct package name when looking up version #2511

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Feb 16, 2023

Fixes #2510.

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2023

Codecov Report

Base: 88.25% // Head: 89.86% // Increases project coverage by +1.60% 🎉

Coverage data is based on head (c257c25) compared to base (0b03010).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2511      +/-   ##
============================================
+ Coverage     88.25%   89.86%   +1.60%     
- Complexity      701      712      +11     
============================================
  Files            32       32              
  Lines          1712     1727      +15     
============================================
+ Hits           1511     1552      +41     
+ Misses          201      175      -26     
Impacted Files Coverage Δ
src/Connection.php 87.95% <100.00%> (-1.08%) ⬇️
src/Eloquent/Model.php 91.66% <0.00%> (-2.05%) ⬇️
src/Auth/PasswordResetServiceProvider.php 100.00% <0.00%> (+66.66%) ⬆️
src/Auth/DatabaseTokenRepository.php 68.18% <0.00%> (+68.18%) ⬆️
src/Auth/PasswordBrokerManager.php 100.00% <0.00%> (+100.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Smolevich
Copy link
Contributor

@alcaeus master branch has changes with laravel 10, maybe to change destination branch from master to 3.9 ?

src/Connection.php Outdated Show resolved Hide resolved
@alcaeus
Copy link
Member Author

alcaeus commented Feb 16, 2023

@Smolevich that's a good point, but there is no 3.9 branch. If you could create one based on the latest 3.9 release and push it I'll rebase and re-target this PR.

@Smolevich
Copy link
Contributor

@Smolevich that's a good point, but there is no 3.9 branch. If you could create one based on the latest 3.9 release and push it I'll rebase and re-target this PR.

Let's do it

@alcaeus
Copy link
Member Author

alcaeus commented Feb 16, 2023

@Smolevich I can't push the branch myself, but once it's pushed this PR can be changed to target 3.9. I've rebased on top of v3.9.4 and dropped all commits related to Laravel 10 support that should not be in 3.9.

@divine divine changed the title Use correct package name when looking up version [3.9] Use correct package name when looking up version Feb 16, 2023
@divine divine changed the base branch from master to 3.9 February 16, 2023 12:19
@divine divine merged commit 6ce35ac into mongodb:3.9 Feb 16, 2023
@divine
Copy link
Contributor

divine commented Feb 16, 2023

We need to update the master branch as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package "jenssegers/laravel-mongodb" is not installed in ^3.9
4 participants