vMix.connected() returns false in connect listener callback

[hrueger]

Hi @jensstigaard,
Thanks for this library. It makes interfacing with vMix very easy.
I did find a small bug though:

this.vMix = new ConnectionTCP(this.settings?.ip || "localhost", { autoReconnect: true });
this.vMix.on("connect", () => { 
    console.log(this.vMix.connected())
}

prints false. The reason I found this is that I do some initialization stuff once vMix is connected. Everything I send to vMix goes through a custom send function which does some logging, then checks whether it is actually connected to vMix and if yes, sends the data.
However, I need to skip this check when I'm inside the callback because the connected() method returns false there.

Best regards

[jensstigaard]

I think that I have found the cause of the problem.. but I do not have the expertise to solve it perfectly. It all comes down to the order of the execution of the listener callbacks. It seems like the custom registered on('connect',...) listener is executed before the internal one, where the variable holding the state is updated.. I however have a quickfix to this issue, wrapping the custom registered listeners with a setTimeout(() => ..., 0) to let the event queue finish up its tasks before firing off the custom listeners.
Code example:

const connection = new ConnectionTCP('localhost', { debug: true })
// Add on connect listener
connection.on('connect', () => {
  console.log('Received connected event clean', connection.connected()) // false
  setTimeout(() => {
    console.log('Received connected event wrapped', connection.connected()) // true
  }, 0)
})

I am not entirely sure whether it is a good idea to implement the quickfix... so I will reflect a liittle on it.

[hrueger]

Maybe we could also use setImmediate instead of setTimeout as it des not check timers and therefore should be a bit faster?