Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpolation in get_cap() removes steps, when there are multiple charge or discharge steps. #307

Open
asbjorul opened this issue Mar 22, 2024 · 0 comments
Assignees
Milestone

Comments

@asbjorul
Copy link
Collaborator

Interpolation in the get_cap()-function removes steps when there are multiple charge or discharge steps in one cycle, e.g. taper steps. In these cases, the interpolation also produces some artefacts in the transition from charge to discharge (when the curve "turns"). This also affects the batchcollectors, which use get_cap() with interpolation turned on as default.

cellpy version: 1.0.1b5
Python version: 3.11
Operating System: Windows 11

Steps to reproduce the behavior: Run cellpy.utils.collectors.BatchCyclesCollector() (which has interpolation turned on as default), for any batch that includes cells with taper steps.

@asbjorul asbjorul changed the title Interpolation in the get_cap() removes steps, when there are multiple charge or discharge steps. Interpolation in get_cap() removes steps, when there are multiple charge or discharge steps. Mar 22, 2024
@jepegit jepegit added this to the v1.0.2 milestone Apr 25, 2024
@jepegit jepegit self-assigned this Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants