Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data files for Biologics support #87

Open
jepegit opened this issue Jul 17, 2018 · 7 comments
Open

Data files for Biologics support #87

jepegit opened this issue Jul 17, 2018 · 7 comments

Comments

@jepegit
Copy link
Owner

jepegit commented Jul 17, 2018

Need to add more mpr files for finalising support for Biologics. Should also get corresponding csv files generated by the Biologics software.

  1. 2-electrode
  • EIS
  • cycles
  • EIS + cycles
  1. 3-electrode
  • EIS
  • cycles
  • EIS + cycles
@jepegit jepegit added this to the v.0.3.0 milestone Jul 22, 2018
@jepegit
Copy link
Owner Author

jepegit commented Jun 23, 2019

The feature has been worked on, but it needs more focused efforts (and at the moment this is not a priority in our group). Changing to milestone v.0.4.0

@jepegit jepegit modified the milestones: v.0.3.0, v.0.4.0 Jun 23, 2019
@jepegit jepegit modified the milestones: v.0.4.0, v.0.5.0 Mar 5, 2021
@jepegit jepegit added this to To do in Release 0.5 Aug 20, 2021
@jepegit jepegit removed this from To do in Release 0.5 Sep 15, 2021
@jepegit jepegit modified the milestones: v.0.5.0, v.0.6.0 Jun 26, 2022
@jepegit jepegit modified the milestones: v.0.6.0, v.1.1.0 Sep 29, 2022
@amundmr
Copy link
Collaborator

amundmr commented Jan 19, 2024

@jepegit We realized that this issue needs to be fixed before really looking into issue #270 . Does it sound like a reasonable idea to use the galvani package as an import instead?

I want to solve the issue in the coming months.

@jepegit
Copy link
Owner Author

jepegit commented Jan 19, 2024

Hi @amundmr Yes, I think that would be a great solution. It might be that I remember wrongly, but it could be that galvani is not extracting the step numbers. But it is probably a fix for that if that is the case. If we mention the git-handle for the maintainer of galvan, will he get a notification do you think?

@jepegit
Copy link
Owner Author

jepegit commented Jan 19, 2024

I will try at least: Hi @chatcannon, how are you doing?

@chatcannon
Copy link

I got a notification. So what you need is to modify galvani to extract step numbers from mpr files?

It has been more than 10 years since the last time I did any electrochemistry experiments myself so I rely on users providing example data files. Also I have a lot of other things to do that are higher priority than unpaid software maintenance.

Realistically your options are:

  1. Implement it yourself, make a pull request and wait a month or two until I get around to looking at it and merging it.
  2. Wait several years or decades until I am in need of a job and decide that working on galvani is the best way to improve my chances in the market.
  3. Pay me consulting rates.
  4. Find a way of solving your problem that doesn't involve me.

@jepegit
Copy link
Owner Author

jepegit commented Jan 20, 2024

Fully understand that @chatcannon, no problem. I am still kind-of doing electrochemical experiments (kind-of = someone else in my team do it and I just look at the results and try to act like I am very smart), so probably we could implement the changes our self. Sorry for the inconvenience and enjoy the rest of the weekend.

@jepegit
Copy link
Owner Author

jepegit commented Jan 20, 2024

@jepegit We realized that this issue needs to be fixed before really looking into issue #270 . Does it sound like a reasonable idea to use the galvani package as an import instead?

I want to solve the issue in the coming months.

Hi @amundmr, I think we should have a look at the biologic-thingy our self. With the great work already done with galvani in "decoding" the binary format, it should not be too difficult to find the step numbers (famous last words). It might actually be that I have done most of the needed work already (need to look through my collection of notebooks and old scripts and then inform you about my findings).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants