Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DATA] Fixed data for FFH.TO #71

Closed
desaijimmy opened this issue Dec 25, 2023 · 4 comments
Closed

[DATA] Fixed data for FFH.TO #71

desaijimmy opened this issue Dec 25, 2023 · 4 comments
Assignees

Comments

@desaijimmy
Copy link

What did you improve in the Database?
Data for the symbol FFH.TO was incorrect. Correct company is Fairfax Financial from Canada, not X Financial from China.

Just wondering: Is there a proper method to validate new changes submitted by users? Otherwise propensity for human induced errors would be quite high.

Drop the files you have updated below (compress to zip if file size too large)
equities.zip

@JerBouma
Copy link
Owner

Thanks for the PRs, will have a look soon. To answer your question, not really other than manual Google searches!

@desaijimmy
Copy link
Author

Thanks Jeroen!

I found a number of other issues (e.g. symbols CAF, EDD, IIF, MS, MSD, etc. all have the name "Morgan Stanley"). Can we connect directly (email) to discuss further? Thanks.

@JerBouma
Copy link
Owner

Thanks Jeroen!

I found a number of other issues (e.g. symbols CAF, EDD, IIF, MS, MSD, etc. all have the name "Morgan Stanley"). Can we connect directly (email) to discuss further? Thanks.

Hi! Interesting, that doesn't seem right. We can chat via LinkedIn (https://www.linkedin.com/in/boumajeroen) or otherwise jer.bouma@gmail.com

JerBouma added a commit that referenced this issue Dec 28, 2023
@JerBouma
Copy link
Owner

Updated the database with these additions, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants