Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE]List of all the available names that can be used in a custom ratio #90

Closed
giraffeingreen opened this issue Dec 28, 2023 · 4 comments

Comments

@giraffeingreen
Copy link

giraffeingreen commented Dec 28, 2023

What's the feature that should be improved?

All the valid names that can be used in a custom ratio.

Describe how you would like the feature improved
Include a list of all the valid names that can be used in a custom ratio.

Possibly describe the ideal way to improve this
Using pandas should be easy to get the column names.

Additional information
At this point in the code you already have all the data available.

total_financials = pd.concat(

@JerBouma
Copy link
Owner

Are you feeding the custom ratios into the Toolkit initialization or directly in the custom ratios function? I can indeed quite easily add it in for the latter!

@JerBouma
Copy link
Owner

Will do a release early this year with this functionality, already have it available on the develop branch.

image

@giraffeingreen
Copy link
Author

That's exactly what I was excepting! Thank you!

@JerBouma
Copy link
Owner

JerBouma commented Jan 2, 2024

@JerBouma JerBouma closed this as completed Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants