Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: _nested_update method in config.py fails to add new keys #10

Open
jerdra opened this issue Dec 7, 2021 · 0 comments
Open

FIX: _nested_update method in config.py fails to add new keys #10

jerdra opened this issue Dec 7, 2021 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@jerdra
Copy link
Owner

jerdra commented Dec 7, 2021

This relates to applying the global configuration settings to each FileSpec object. When a key is missing from a FileSpec configuration that is present in the global the intended behaviour is that the key defined in global gets inserted into the FileSpec configuration.

Currently this operation does not insert keys if missing i.e if:

bids_map:
   sub:
     regex: ABC

is defined under globals and the FileSpec bids_map is missing sub, then we should expect that sub gets inserted into a FileSpec's bids_map. But currently this is not the case.

The fix should be implemented in _nested_update in niviz/config.py to add keys when missing. In addition, only keys intended to be used in the FileSpec definition should be used, in which case we may need a FileSpec context (key) under global so we know which keys can be applied to FileSpec items.

@jerdra jerdra added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers and removed help wanted Extra attention is needed labels Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant