Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Github Actions #226

Merged
merged 8 commits into from
Mar 17, 2020
Merged

Use Github Actions #226

merged 8 commits into from
Mar 17, 2020

Conversation

jherdman
Copy link
Contributor

@jherdman jherdman commented Mar 17, 2020

Tests and Lints the project.

Note that I've not yet deleted the Travis config. I feel like that should be done once we're happy with this and decide to proceed with this approach.

Areas of Possible Improvement

  • Cache Dialyzer
  • Cache deps
  • Cache build
  • Publishing upon tagging a release

Currently this just runs the test command with Mix. Next I'll look into
our linting steps.
@jherdman jherdman marked this pull request as ready for review March 17, 2020 17:40
Copy link
Member

@doomspork doomspork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dialyzer will be tough. I have not been able to get the Actions Cache step to do the trick, maybe someone else can 🎉

@jherdman
Copy link
Contributor Author

I'll open a "help wanted" ticket for that. It'd certainly be nice. It's relatively easy to do on services like Circle.

@lucacorti
Copy link
Contributor

Hey guys, I've setup action cache for dialyzer for a few of my projects, it's quite straightforward, here is an excerpt from my job

on: [push]

jobs:
  test:
    runs-on: ubuntu-latest
    name: OTP ${{matrix.otp}} / Elixir ${{matrix.elixir}}
    strategy:
      matrix:
        otp: [21.3.8.13, 22.2.8]
        elixir: [1.9.4, 1.10.2]
    steps:
      - uses: actions/checkout@v2
      - uses: actions/setup-elixir@v1
        with:
          otp-version: ${{matrix.otp}}
          elixir-version: ${{matrix.elixir}}
      - uses: actions/cache@v1
        env:
          cache-name: mix
        with:
          path: ~/.mix
          key: ${{ runner.os }}-${{ env.cache-name }}-${{ matrix.otp }}-${{ matrix.elixir }}
          restore-keys: |
             ${{ runner.os }}-${{ env.cache-name }}-
      - uses: actions/cache@v1
        env:
          cache-name: build
        with:
          path: _build
          key: ${{ runner.os }}-${{ env.cache-name }}-${{ matrix.otp }}-${{ matrix.elixir }}
          restore-keys: |
             ${{ runner.os }}-${{ env.cache-name }}-

@jherdman
Copy link
Contributor Author

@lucacorti would you be interested in opening a PR once this is merged so that you get appropriate credit?

@lucacorti
Copy link
Contributor

@jherdman sure, no problem, or you can get it in and the credit too 😄

@jherdman jherdman merged commit cda9303 into master Mar 17, 2020
@jherdman jherdman deleted the try-github-actions branch March 17, 2020 21:26
@jherdman
Copy link
Contributor Author

@lucacorti merged! Feel free to open a PR whenever you have time.

@lucacorti
Copy link
Contributor

@jherdman time is abundant right now, I live in italy, so I'm forced at home 😭 I've opened a PR, testing it right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants