New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/example #5
Fix/example #5
Conversation
Fix enum_test in dart_example
Remove unused import in dart_example/enum_test
This PR also include #4 😅 |
@Roms1383 thanks for your contribution! I'll review it shortly. |
Thank you for your pull request @Roms1383, very well organized. I have pulled in some of your changes as part of 566cb17. Here's some feedback on the commits that I skipped over and why:
Thanks for your contribution, I'll close this PR as I merged the above manually. |
Ah thanks for your feedback, I learned a couple of things here! |
Hello again!
I could correctly build the plugin so far,
then I tried to run the tests in the generated
dart_example
folder but there was a few minor obstacles:test
dependency was missing indart_example/pubspec.yml
fixed
dart_example/test/enum_test.dart
for a reason that I ignore I had to build with crate type
dylib
manually copy built Rust library to
../dart_example/libexample.dylib
probably because on M1 I'm required to run:
which builds to
example/target/x86_64-apple-darwin/debug/libexample.dylib
instead.Library is called
libexample.dylib
, as per generator lib argwhile some binaries are called
generator
/generator.d
after Cargo bin namehonestly I'm not sure if it matters, but in case.
Now, it runs smooth :)