-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support __DIR__ etc. #16
Comments
I can't speak for the Laravel documentation, but SuperClosure should handle magic constants just fine. One of the features on the README says, "Replaces magic constants with their expected values so that the closure behaves as expected after unserialization". The two visitor classes help make this possible. Now, if you've tried it, and it is not working, then I would consider it a bug. Have you tried it, or are you just going off what the Laravel docs say? Prior to about September last year, Laravel did not use the SuperClosure package (it was using an older, vendored version of SuperClosure). At that point in time, that piece of documentation was probably true. If |
Thanks for the feedback, I'll contact Laravel's developer and will report back to you. |
Looks like it was just an oversight. Thank you, great library by the way! |
Works beautifully, thanks! |
The Laravel documentation makes me think that having constants like
__DIR__
in a serialized closure will break things.Do you think that we could build some magic around this?
The text was updated successfully, but these errors were encountered: